Giter Club home page Giter Club logo

Comments (15)

erawhctim avatar erawhctim commented on June 12, 2024 1

@aghontpi I just pulled up the latest episode of Joe Rogan's podcast to test. Ads appear after a little while, though (not immediate), and the exact point in time where they trigger the ad(s) seems to vary slightly between episodes.

The ad appears as a different "track" and has its own standalone notification (which seems to be what your app needs to detect with). I can try running locally and searching in the logs; I'll see if I can copy them and post here.

from ad-silence.

aghontpi avatar aghontpi commented on June 12, 2024 1

Thanks!, I found it on his pod cast.

this is a great find!! thanks to you.

bug spotify bug

from ad-silence.

citizenserious avatar citizenserious commented on June 12, 2024 1

Screenshot_20220701-101926_Spotify
Screenshot_20220701-101856_Finanzguru
@aghontpi, thats not the case, it is advertisment for other podcasts The screenshot that I shared shows the advertised podcast, not the one that I listen to.
In the first picture you can see that it is labeled as "ADVERTISEMENT FROM Spotify"

from ad-silence.

aghontpi avatar aghontpi commented on June 12, 2024

I haven't tested podcasts in spotify, I'll check them out.

you can check the line below in logs

Log.v(
TAG,
"detected ${appNotification.context.getString(R.string.spotify)} -> ${
appNotification.context.getString(R.string.spotify_package_name)
}"
)

from ad-silence.

aghontpi avatar aghontpi commented on June 12, 2024

okey, so I tried running podcasts on a account with no subscription, I did not get ads in them to test. (not including the ads baked into the episode itself by the creator)

can you link the podcasts?, if you dont want to share it publicly, send it to me directly.

from ad-silence.

aghontpi avatar aghontpi commented on June 12, 2024

the build below should cover the same.

(rename .zip to .apk, limitations in github comments)
app-release.zip

testing for a day before closing this.

update: tested, closing..

from ad-silence.

ouzowtf avatar ouzowtf commented on June 12, 2024

Just installed version 0.9.1 to test this with Spotify and I got ads playing while playing an auto-generated playlist ("Your mixtape")

(Pixel 4a 5G on Android 12)

from ad-silence.

aghontpi avatar aghontpi commented on June 12, 2024

yea 0.2.1. @ouzowtf I tried mixtape, the ad shows up but the app detects and silences it. I'll keep on testing it in the upcoming days.., meanwhile I'm keeping this issue closed (since this is related to podcasts), you can open a new issue.

from ad-silence.

citizenserious avatar citizenserious commented on June 12, 2024

Screenshot_20220430-211919_Shade_Launcher
I use Spotify premium, but I still have advertisement while listening to podcasts. Unfortunately ad silencing doesn't work. Maybe it is not working because the ads are labeled as "Spotify" instead as advertisement?

from ad-silence.

aghontpi avatar aghontpi commented on June 12, 2024

@citizenserious maybe the ads are baked in the original podcast file/audio by the creator.

from ad-silence.

aghontpi avatar aghontpi commented on June 12, 2024

@citizenserious there is no mention of "ad" in the song title or notification. how do we block this..

The artist name is Spotify maybe that can be used 🤔

from ad-silence.

citizenserious avatar citizenserious commented on June 12, 2024

@aghontpi Exactly, I think that is the problem here. We could try to add Spotify but I do not know if there are any side affects like false blocking or worse. I would test it for a while if you like to provide a test version. (:

from ad-silence.

aghontpi avatar aghontpi commented on June 12, 2024

@citizenserious, yea true.

I'll refactor/ do the changes and tag you in #63 with the build

from ad-silence.

citizenserious avatar citizenserious commented on June 12, 2024

@aghontpi you are the best! Thank you very much for your work.

from ad-silence.

citizenserious avatar citizenserious commented on June 12, 2024

@aghontpi

I found several Sponsors which are not silenced yet:

Screenshot_20230524-142611_Spotify
Screenshot_20230524-142748_OctoDroid
![Screenshot_20230524-142658_Spotify](https://github.com/aghontpi/ad-silence/assets/62773866/3282edc3-8b0a-4c80-b952-53
Screenshot_20230524-142803_OctoDroid
a93261f021)
Screenshot_20230524-142626_Spotify

If you could show me how you added it last time I am willing to try it myself, but consider, that I never partisipaded at a project on github or any comparable platform.
Maybe I could start with that, trying to participate at this awesome project (:

from ad-silence.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.