Giter Club home page Giter Club logo

Comments (19)

aghontpi avatar aghontpi commented on June 1, 2024 1

added support for Deezer in #11 , closing this issue.

@Cwpute thanks for request !

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

Thanks for the suggestion, will add it for sure.

Happy Holidays!

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

block deezer ads

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

deezer is not available in my country and is region locked, (even after using vpn, the app wont let me signin). I have to find a way to overcome this.

is it supported in your country? or are you using a method(vpn,etc...) to make it work?

from ad-silence.

Cwpute avatar Cwpute commented on June 1, 2024

Yes it is supported in my country (France). I didn't know it would be blocked in others !

from ad-silence.

Cwpute avatar Cwpute commented on June 1, 2024

Fantastic ! thank you !!

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

😄 yw.

I have to test it for a few days before publishing it, so If you want to test it immediately head over here.

You can also provide feedback on whether it works or not, (im limited to an emulator 😭 , it would be of great help)

from ad-silence.

Cwpute avatar Cwpute commented on June 1, 2024

Tested it just now and it doesn't work :/ the app is running in the notifications and Deezer is checked on in the settings. Not sure why it doesn't work.

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

I just tested it now, works as expected 🤔

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

can you take a screenshot of the Deezer notification when an ad plays next time and post it here.

from ad-silence.

Cwpute avatar Cwpute commented on June 1, 2024

Screenshot_20211231-203630

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

thanks for the screenshot, from the notifications..

  • either ad-silence/app did not recognise the notification or it was killed by system (but if the system has killed it, there would be no notification in the first place)

I can tell the above has happened for sure, because if a configured app (i.e) "Deezer/Spotify.. in preference" posts a new notification, the title of ad-silence would be "Ad-silence . now" but it shows "Ad-silence . 16h", which indicates adsilence last detected something 16 hours ago and did not detect Deezer or anything since. (can you test it again with the build 10 from #11)

or the app might be killed (but notification is not removed...which has a less probability, need logcat to confirm this)

Can you specify the device model/specs? (optional, if you are into dev.. and have a pc, can you take a logcat?. I can send you the instructions)

edit/update: do mention if it works for other apps (spotify/accuradio/Tidal)

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

If I have extra time available, I can decomple/reverse engineer the Deezer app to patch the location restriction..then I can test it on my device, fingers crossed~

from ad-silence.

Cwpute avatar Cwpute commented on June 1, 2024

My phone is a Huawei Y5 2018 DRA-L21 running on Android 8.10.
I don't think the app was killed as it was listed in the opened-apps window as Deezer was playing.
I'll try to use it with Spotify !
Last time i tried to use Logcat it didn't work… but if someone helps me through i might be able to use it.

from ad-silence.

Cwpute avatar Cwpute commented on June 1, 2024

It works perfectly with Spotify on the same device… so the issue must be specific to the Deezer app.

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

there should be no hiccups for android 8 andad-silence would not show up in recents 🤔 (its configured not to be seen in recents screen/running apps screen). but Spotify works.. so it clears the possibility of system killing the app.

What problems did you face ? I can help you set it up.

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

Can you verify Deezer's package name is deezer.android.app, it will be under app Info.

from ad-silence.

aghontpi avatar aghontpi commented on June 1, 2024

An update~

I have decided it would be better to merge the Deezer branch #11 into master instead of keeping it stale, So others can test this and report.

Put Deezer under an experimental section and ship with main build. (something like below or a better UI)

experimental-example-ui

from ad-silence.

famewolf avatar famewolf commented on June 1, 2024

I have not seen deezer in the list. If it's hidden unless the app is installed I can install it and try to get a logcat along with some screenshots.

from ad-silence.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.