Comments (19)
added support for Deezer in #11 , closing this issue.
@Cwpute thanks for request !
from ad-silence.
Thanks for the suggestion, will add it for sure.
Happy Holidays!
from ad-silence.
from ad-silence.
deezer is not available in my country and is region locked, (even after using vpn, the app wont let me signin). I have to find a way to overcome this.
is it supported in your country? or are you using a method(vpn,etc...) to make it work?
from ad-silence.
Yes it is supported in my country (France). I didn't know it would be blocked in others !
from ad-silence.
Fantastic ! thank you !!
from ad-silence.
😄 yw.
I have to test it for a few days before publishing it, so If you want to test it immediately head over here.
You can also provide feedback on whether it works or not, (im limited to an emulator 😭 , it would be of great help)
from ad-silence.
Tested it just now and it doesn't work :/ the app is running in the notifications and Deezer is checked on in the settings. Not sure why it doesn't work.
from ad-silence.
I just tested it now, works as expected 🤔
from ad-silence.
can you take a screenshot of the Deezer notification when an ad plays next time and post it here.
from ad-silence.
from ad-silence.
thanks for the screenshot, from the notifications..
- either
ad-silence/app
did not recognise the notification or it was killed by system (but if the system has killed it, there would be no notification in the first place)
I can tell the above has happened for sure, because if a configured app
(i.e) "Deezer/Spotify.. in preference
" posts a new notification, the title of ad-silence
would be "Ad-silence . now
" but it shows "Ad-silence . 16h
", which indicates adsilence
last detected something 16 hours ago and did not detect Deezer or anything since. (can you test it again with the build 10
from #11)
or the app might be killed (but notification is not removed...which has a less probability, need logcat to confirm this)
Can you specify the device model/specs? (optional, if you are into dev.. and have a pc, can you take a logcat?. I can send you the instructions)
edit/update: do mention if it works for other apps (spotify/accuradio/Tidal)
from ad-silence.
If I have extra time available, I can decomple/reverse engineer the Deezer app to patch the location restriction..then I can test it on my device, fingers crossed~
from ad-silence.
My phone is a Huawei Y5 2018 DRA-L21 running on Android 8.10.
I don't think the app was killed as it was listed in the opened-apps window as Deezer was playing.
I'll try to use it with Spotify !
Last time i tried to use Logcat it didn't work… but if someone helps me through i might be able to use it.
from ad-silence.
It works perfectly with Spotify on the same device… so the issue must be specific to the Deezer app.
from ad-silence.
there should be no hiccups for android 8 andad-silence
would not show up in recents 🤔 (its configured not to be seen in recents screen/running apps screen). but Spotify works.. so it clears the possibility of system killing the app.
What problems did you face ? I can help you set it up.
from ad-silence.
Can you verify Deezer's package name is deezer.android.app
, it will be under app Info.
from ad-silence.
An update~
I have decided it would be better to merge the Deezer branch #11 into master instead of keeping it stale, So others can test this and report.
Put Deezer under an experimental section and ship with main build. (something like below or a better UI)
from ad-silence.
I have not seen deezer in the list. If it's hidden unless the app is installed I can install it and try to get a logcat along with some screenshots.
from ad-silence.
Related Issues (20)
- me.zhanghai.android.files.file_provider/file%253A%252F%252F%252Fstorage%252Femulated%252F0%252FAndroid%252Fdata%252Fme.zhanghai.android.files%252Fcache%252Fopen_cache%252FREADME.txt
- Not working properly! HOT 1
- Restricted setting HOT 5
- Add support for Soundcloud HOT 2
- Ninho
- Leortami19
- AD: Pandora Showed "Curator Message"
- hhhhhg
- SoundCloud HOT 1
- Ad at spotify unmute before the end HOT 2
- DuoLingo ads :owl: HOT 2
- Azer
- Music
- M
- Maszunia HOT 4
- [Bug] HOT 3
- Hhhh HOT 1
- Not working for Spotify.
- Catalan support HOT 3
- Spotify
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ad-silence.