Giter Club home page Giter Club logo

Comments (5)

gallais avatar gallais commented on July 16, 2024

The ability to stack layout keywords on a single line is only recent (agda/agda#5319)
so I would not say it's a preferred style, more of an accident of history.
I have no opinion on what the preferred style should be.

from agda-stdlib.

JacquesCarette avatar JacquesCarette commented on July 16, 2024

Indeed - well, this issue can still serve as a place to figure out what we want. As I prefer vertically-denser code, I'd be quite open to shifting to the stacked style!

from agda-stdlib.

jamesmckinna avatar jamesmckinna commented on July 16, 2024

Thanks for raising this @JacquesCarette and @omelkonian for drawing attention to it.

FWIW, I prefer the 'layered, indented' style, except when there is a single declaration, typically of a module declaration echoing an imported/parameter record in order to permit easier access to named/manifest fields equally.

Not least because not all opening private blocks contain only one kind of declaration...

PR incoming...

from agda-stdlib.

JacquesCarette avatar JacquesCarette commented on July 16, 2024

Certainly where there are multiple kinds of variable declarations, or a private block that has multiple things in it, we should go for the indented style.

I guess the main question is when it all naturally fits on one line and is conceptually a single thing, we should allow that?

from agda-stdlib.

jamesmckinna avatar jamesmckinna commented on July 16, 2024

I'm maybe (known to be) more profligate with whitespace, so perhaps not?

But the main criterion I guess should be consistency above all else...

from agda-stdlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.