Giter Club home page Giter Club logo

Comments (4)

mattt avatar mattt commented on June 23, 2024

Content-Type is a header, not a parameter. The correct MIME type should be automatically provided if the file extension is .jpg or .jpeg. If not, the request serializer can override this.

from afamazons3manager.

ransomweaver avatar ransomweaver commented on June 23, 2024

You are sure this is the case for PUT, not POST? The code in AFAmazonS3Manager is this:

 NSData *data = [NSURLConnection sendSynchronousRequest:fileRequest returningResponse:&response error:&fileError];

If I log the mimetype:

NSLog(@"mimetype is %@", [response MIMEType]); // for me this shows "image/jpeg" for the local file

then POST OR PUT:

POST uses

[formData appendPartWithFileData:data name:@"file" 
fileName:[filePath lastPathComponent] mimeType:[response MIMEType]];

but PUT does

request = [self.requestSerializer requestWithMethod:method URLString:[[self.baseURL URLByAppendingPathComponent:destinationPath] absoluteString] parameters:nil error:nil];

    // S3 expects parameters as headers for PUT requests
    if (parameters != nil) {
        for (id key in parameters) {
            [request setValue:[parameters objectForKey:key] forHTTPHeaderField:key];
        }
    }

    request.HTTPBody = data;

The ".jpg" is at the end of destinationPath...is that how the request serializer is supposed to figure out the mime type? A custom request serializer is required here?

from afamazons3manager.

btrimble avatar btrimble commented on June 23, 2024

This seems like a bug or a lack of functionality. putObject doesn't allow for setting headers that factor into the auth signature because the headers (passed as parameters) are set on the request after the auth signature is generated. This leads to a 403 from S3.

You can subclass the request serializer but it ends up duplicating code. Even then you can only set headers that are derived from information that's in the request like Content-Type from file extension or an MD5 hash. You can't specify 'x-amz-acl' header for instance.

from afamazons3manager.

chrisallick avatar chrisallick commented on June 23, 2024

Would love for this to be fixed.

from afamazons3manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.