Potential Memory Leak about arvideokit HOT 10 OPEN

Thank you!

To give you a little more context, in my case I have a button that can switch between AR camera and normal camera. So if you choose to programmatically initialize and add ARSCNView to the view hierarchy based on certain action. You'll have UIViewController holding a strong reference to ARSCNView, UIViewController holding a strong reference to RecordAR and RecordAR holding a strong reference to ARSCNView. And I saw in your source code RecordAR also holds a strong reference to ARSCNView's parent view controller which might cause a retain cycle (Didn't look too deep into the source code, I think this is the case).

from arvideokit.

Will investigate the issue and get back to you soon.

from arvideokit.

facing the same issue. RecordAR holding strong reference to the ARSCNView.

from arvideokit.

@mssjappjwt did you find any workaround for this like passing unowned or weak ARSCNView ?

from arvideokit.

how to fix

from arvideokit.

Facing same issue, app crashing..

from arvideokit.

Facing same issue, app crashing..

from arvideokit.

Taking a global strong reference to view object is a bad idea:

import Foundation
import ARKit

private var view: Any? // this must be instance & weak variable!
private var renderEngine: SCNRenderer! // instance variable too 

@available(iOS 11.0, *)
struct RenderAR {
    var ARcontentMode: ARFrameMode!
    .....

... and other classes.

from arvideokit.

@dneprDroid

Feel free to submit a pull request with the fixes.

from arvideokit.

I have checked it, and with these changes component is deallocated. #82

from arvideokit.