Giter Club home page Giter Club logo

Comments (6)

Aerilius avatar Aerilius commented on June 13, 2024

The icons have been purposely not set to very dark colors so that they should be distinguishable from black background. I see that fails if the background is a similar gray.

It's probably not trivial to make images flip color (in contrast to fonts), unless I encode them in icon fonts, which will probably break on legacy systems that don't support webfonts.

from sketchup-console-plus.

Aerilius avatar Aerilius commented on June 13, 2024

Does commit 5dc2b6b in branch issue-dark-themes improve the situation?

from sketchup-console-plus.

DanRathbun avatar DanRathbun commented on June 13, 2024

The manually downloaded master (v3.0.2) looks the same.

The best thing going forward would be to have a "themes" folder and beneath that separate named theme folders that have the css and images files in them. Along with a way for user to set the theme.
Then people could contribute theme folders to the project.

from sketchup-console-plus.

Aerilius avatar Aerilius commented on June 13, 2024

That branch is not in a release, only in the source repository.

Hmm, so far there were not yet a lot of people requesting this to justify themeability as a feature, but I'll wait and see. For now, I don't have a problem with users just overwriting the icon resources in the images folder. Or adding in the css file .toolbar button img { filter: brightness(+200%); }. But I cannot detect the actual color values of the OS theme, I cannot flip such a filter programmatically.

from sketchup-console-plus.

DanRathbun avatar DanRathbun commented on June 13, 2024

Hmm, so far there were not yet a lot of people requesting this to justify themeability as a feature, but I'll wait and see.

Yeah, well it looks like I'm leaving SketchUp plugin development behind, so it will not affect me going forward.

from sketchup-console-plus.

DanRathbun avatar DanRathbun commented on June 13, 2024

But I cannot detect the actual color values of the OS theme ...

https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model/Examples#Example_6:_getComputedStyle ?

https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/Using_dynamic_styling_information

Or adding in the css file .toolbar button img { filter: brightness(+200%); }
... I cannot flip such a filter programmatically.

rules = document.styleSheets[0].cssRules
for (var i = 0; i < rules.length-1; i++) { 
    if (rules[i].selectorText == ".toolbar button img") {
        rules[i].style.setProperty("filter", "brightness(100%)");  
        break;
    }
}

?

from sketchup-console-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.