Giter Club home page Giter Club logo

Comments (5)

AlexGluck avatar AlexGluck commented on September 24, 2024 2
  1. Before we implement PodTemplate, i suggest add opt-in image in spec
  2. Solution for storage persistent: false use emptyDir, if not set default value true
  3. Solution for storage value storageClass opt-in, if not set use default storage class
---
apiVersion: etcd.aenix.io/v1alpha1
kind: EtcdCluster
metadata:
  name: test
  namespace: ns1
spec:
  replicas: 3
  image: ""
  persistent: false
  storage:
    size: 10Gi
status:
  conditions:
  - lastProbeTime: null
     lastTransitionTime: "2024-03-06T18:39:39Z"
     status: "True"
     type: Initialized
  - lastProbeTime: null
     lastTransitionTime: "2024-03-06T18:39:45Z"
     status: "True"
     type: Ready
  - lastProbeTime: null
     lastTransitionTime: "2024-03-06T18:39:45Z"
     status: "True"
     type: Synchronized
...

from etcd-operator.

sedovandrew avatar sedovandrew commented on September 24, 2024
  1. I would suggest specifying the Etc version of the cluster in the spec. By default, the operator will use the latest version of Etc known to him, for example, v3.5.12 at the moment. Also specify the version in status, so that the operator understands which cluster he is servicing.
  2. I didn't see the field for the storage class.

I suggest adding the following fields:

spec:
  storage:
    class: storage-class-name  # optional #2
  version: v3.5.12  # optional #1
status:
  version: v3.5.12  # #1

Final manifest:

apiVersion: etcd.aenix.io/v1alpha1
kind: EtcdCluster
metadata:
  name: test
  namespace: ns1
spec:
  replicas: 3
  image: ""
  persistent: false
  storage:
    class: storage-class-name  # optional #2
    size: 10Gi
  version: v3.5.12  # optional #1
status:
  conditions:
  - lastProbeTime: null
     lastTransitionTime: "2024-03-06T18:39:39Z"
     status: "True"
     type: Initialized
  - lastProbeTime: null
     lastTransitionTime: "2024-03-06T18:39:45Z"
     status: "True"
     type: Ready
  - lastProbeTime: null
     lastTransitionTime: "2024-03-06T18:39:45Z"
     status: "True"
     type: Synchronized
  version: v3.5.12  # #1

It is also worth considering the list of Etcd versions supported by the operator.

from etcd-operator.

sircthulhu avatar sircthulhu commented on September 24, 2024

@AlexGluck thanks for your suggestions.
I think I will include them in my implementation.

Is there a reason for persistence field to be not in the .spec.storage but .spec?

from etcd-operator.

kvaps avatar kvaps commented on September 24, 2024

Fixed by #15 and #16

from etcd-operator.

AlexGluck avatar AlexGluck commented on September 24, 2024

Is there a reason for persistence field to be not in the .spec.storage but .spec?

Nope

from etcd-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.