Comments (3)
I suggest before accept PR #63 move key image
under podSpec.
from etcd-operator.
Agree with @AlexGluck that two keys would be too much. From the other point of view - podSpec
is redundant for us. And we can just use the subset of keys from there like affinity, tolerations etc., which are important and should be customisable by the end user. But it will lead to massive work for preparing our own version of spec. Or otherwise we can just use podSpec
and fill the proper spec fields by admission controller. So effectively taking spec.image
and putting it into proper place of podSpec
.
Why do I so insist on using spec.image
? Because it is obviuos that it is much more important and more frequent to be changed than other fields from podSpec
. So logically it should as close to the root key spec
as possible.
from etcd-operator.
For now we have 2 options about field placement:
spec.image
spec.podSpec.image
We will decide it with community vote in https://t.me/etcd_operator/4054 and comment decision here
from etcd-operator.
Related Issues (20)
- Update helm-docs configuration, custom template
- Steps to publish new release HOT 1
- E2e tests HOT 4
- Development documentation HOT 2
- Add dependabot HOT 1
- Add missing fields for podTemplate.spec
- Implement serviceAccountSpec
- [epic] API Design for EtcdCluster resource HOT 8
- Rename podSpec to podTemplate and podDistruptionBudget to podDistruptionBudgetTemplate
- Replace extraArgs to be a list, not map HOT 1
- Add the ability to specify volumes and containers HOT 1
- Add serviceTemplate
- Allow customization for all managed resources
- [Helm] Security policy in Talos Linux HOT 1
- CRD updating in helm-chart using pre-commit
- CRDs deployment approach HOT 1
- Add ability to customize probe settings in podSpec
- Add image field to spec and implement it HOT 1
- Revisit ResourceVersion usage in resource factories HOT 3
- Problem with pod restart stability HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from etcd-operator.