Giter Club home page Giter Club logo

Comments (3)

AlexGluck avatar AlexGluck commented on September 24, 2024

I suggest before accept PR #63 move key image under podSpec.

from etcd-operator.

gecube avatar gecube commented on September 24, 2024

Agree with @AlexGluck that two keys would be too much. From the other point of view - podSpec is redundant for us. And we can just use the subset of keys from there like affinity, tolerations etc., which are important and should be customisable by the end user. But it will lead to massive work for preparing our own version of spec. Or otherwise we can just use podSpec and fill the proper spec fields by admission controller. So effectively taking spec.image and putting it into proper place of podSpec.

Why do I so insist on using spec.image? Because it is obviuos that it is much more important and more frequent to be changed than other fields from podSpec. So logically it should as close to the root key spec as possible.

from etcd-operator.

sergeyshevch avatar sergeyshevch commented on September 24, 2024

For now we have 2 options about field placement:

  • spec.image
  • spec.podSpec.image

We will decide it with community vote in https://t.me/etcd_operator/4054 and comment decision here

from etcd-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.