Giter Club home page Giter Club logo

Comments (13)

Exaxxion avatar Exaxxion commented on August 16, 2024

I suspect (but haven't looked at it beyond your screenshots) that this is the case because the fuzzy damage function compares items which store damage in a vanilla way using metadata values. I think the coolant cells are storing their damage using NBT tags (which is interpreted by AE2 as them being distinct items).

from applied-energistics-2.

gatoborrachon avatar gatoborrachon commented on August 16, 2024

well, i think you are right:

1.- i have 2 IC2 addons (GregTech Experimental and FrogCraft) that add Coolant Cells

2.- GregTech Experimental (and IC2) Coolant Cells store their damage using the NBT "AdvDmg"
2.1.- But FrogCraft uses Metadata, and in one test i did, it seemed to work (i will do a new try to confirm this)

3.- But as far as i know, someone in the Unofficial AE2 Discord Server told me that the Fuzzy Card recognizes NBT too, but idk if it only recognize a NBT called 'damage' or something like this, so i think that we just need to add that NBT 'AdvDmg' as one of the recognized NBT values (if this is the case of course).

from applied-energistics-2.

gatoborrachon avatar gatoborrachon commented on August 16, 2024

sorry, i can't believe i forgot it

I think the coolant cells are storing their damage using NBT tags (which is interpreted by AE2 as them being distinct items).

but then why the Import Bus works perfectly fine? (maybe inside the code of the Import bus there's the key to solve this issue, but i really don't know)

from applied-energistics-2.

PrototypeTrousers avatar PrototypeTrousers commented on August 16, 2024

heres an old issue on the original ae2 issue-tracker explaining why it this way:
AppliedEnergistics#3361

TL;DR: I couldnt make it work.

from applied-energistics-2.

gatoborrachon avatar gatoborrachon commented on August 16, 2024

TL;DR: I couldnt make it work.

we can't ask for help from that guy? (the guy from this video: https://www.youtube.com/watch?v=VB0lgmBu0pI)

EDIT: He said this:

I have already deleted that code, but tomorrow I can look again and describe in more detail how to fix it

Or, in the other hand, what exactly i would require to do to fix this? (in a personal fork)

from applied-energistics-2.

theArhar avatar theArhar commented on August 16, 2024

So I searched my computer and found some difference between github version of rv5-stable.5-1.12 and what I have now
I am adding files mentioned in previous topic
new.zip
in ItemComparisonHelper I added block from line 106
in AEItemStack - getMaxDamage 338
in AESharedItemStack - many alters, line 47, isDamageable, getCustomDamage, getMaxDamage, etc, see comparison
also it can be that github version is slightly different from what I have downloaded 3 years ago, so feel free to ask more questions

from applied-energistics-2.

gatoborrachon avatar gatoborrachon commented on August 16, 2024

in AEItemStack - getMaxDamage 338

mmm, well, it seems that many things changed since rv5-stable.5-1.12, i simply can't override getMaxDamage

in AESharedItemStack - many alters, line 47, isDamageable, getCustomDamage, getMaxDamage, etc, see comparison

here too, no one of these functions are able to be overrided

from applied-energistics-2.

theArhar avatar theArhar commented on August 16, 2024

How do you trying to compile your project? What IDE do you use?

from applied-energistics-2.

theArhar avatar theArhar commented on August 16, 2024

I managed to successfully rewrite rv6-stable7 code with same fix (some places are different, but logic the same) and it works
2021-05-22_14 22 26
2021-05-22_14 22 46
2021-05-22_14 23 04
2021-05-22_14 23 09
2021-05-22_14 23 18

from applied-energistics-2.

theArhar avatar theArhar commented on August 16, 2024

notice 2499 damage on pic.2 - this is crucial, it must be strictly lower than 2500
edited files will be in zip
rv6-stable7.zip

from applied-energistics-2.

theArhar avatar theArhar commented on August 16, 2024

notice, you probably want to remove AELog (125,126,127) in ItemComparisonHelper

from applied-energistics-2.

gatoborrachon avatar gatoborrachon commented on August 16, 2024

my god, thank you so much, i will build the dev environment with the fixes ASAP
(As soon as i can test it, i will close this issue, give me an hour, i have to do a thing first)

How do you trying to compile your project? What IDE do you use?

As always, gradlew setupDecompWorkspace, and since i'm using Eclipse: gradlew eclipse

from applied-energistics-2.

gatoborrachon avatar gatoborrachon commented on August 16, 2024

sorry for the relay, i were a bit busy

and yeah, it totally worked, every coolant cell is being moved at the specified damage, i also tried the ME System with the Regen Reactor and it works precfectly too, many thanks

System working
2021-05-22_17 52 55

2021-05-22_17 58 11

System with the Regen Reactor
2021-05-22_17 52 58

Cells being inserted:
2021-05-22_17 53 08

Cells being removed (50% in Fuzzy Card):
2021-05-22_17 56 39

from applied-energistics-2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.