Comments (6)
@KadoBOT Thank you for your advices.
Regarding your previous message I was able to apply workaround:
import "@adyen/api-library/dist/lib/src/typings";
in specific file"declaration": true
in compositetsconfig.json
project
from adyen-node-api-library.
Hi @splacentino
You don't import type definition files. All types are already compiled and available within the library (see here), which means you don't need to import the types to use them if you are using the library.
I just tested your code, and this works:
import { Client, CheckoutAPI } from '@adyen/api-library'
const client = new Client({ apiKey: '1234', environment: 'TEST' })
const checkout = new CheckoutAPI(client)
function getPaymentMethods(): Promise<ICheckout.PaymentMethodsResponse> {
return checkout.paymentMethods({ merchantAccount: 'testMerchantAccount' })
}
Also, in your case, the return type is inherited, based on the type definitions of the checkout.paymentMethods
. Since you manually specified the return type, you are telling the compiler that the expected return type is PaymentResponse
, when the correct one is PaymentMethodsResponse
, which is wrong. So in this case, you don't need to specify the return type:
from adyen-node-api-library.
Since this is not a bug, I'll close the issue. But feel free to leave any comments.
from adyen-node-api-library.
Hi @KadoBOT
I made a typo in the example, indeed.
Self types import does not look good enough. Could you try with two separate projects a
and b
where b
is composite ts project imported in project a
.
Transpilation of project b
when building project a
(tsc --build
) will throw an error regarding types.
from adyen-node-api-library.
How the project is currently set up, it expects you to have the library installed. So it indeed it might fail for cases like yours. If you need to use the types on a different project, you would need the types to be independent, in other words, to be a package (i.e @types/@adyen/api-library).
If you feel like, you can open a feature request for that, but that would depend on more requests as is not a priority for us right now. Or, you can add the types to the @types
repo yourself.
Lemme know if that helps.
from adyen-node-api-library.
@splacentino that's great! Thanks for the update.
from adyen-node-api-library.
Related Issues (20)
- [BUG] getAllPaymentMethods() is not properly deserialized HOT 1
- [BUG] Requesting ForceEntryMode fails beacuse of incorrect serialization HOT 1
- Confusion about your release in npmjs.com HOT 2
- [BUG] Checkout API-Typings is not v70 ./. Typings for PaymentRequest are not up to date HOT 2
- [FEATURE] Add session get status function to the library HOT 2
- [BUG] TypeError: data.toISOString is not a function HOT 1
- [BUG] getResultOfPaymentSession misses required sessionResult HOT 3
- [BUG] Missing Action data in PaymentDetailsResponse class HOT 7
- [BUG] Websites guide is showing wrong documentation HOT 1
- Best practices for mocking with jest HOT 1
- SessionResult parameter is missing in the getResultOfPaymentSession method HOT 2
- [BUG] @adyen/api-library v15.1.0 not available in npmjs.com registry HOT 5
- additionalData property in NotificationRequestItem seems to be typed incorrectly HOT 2
- [BUG] LoyaltyID missing in PaymentResponse and CardAcquisitionResponse HOT 2
- [BUG]Shopper country is not shown in customer area despite been passed in payment request
- [BUG] Missing property response value "Refused" for synchronous authorisation adjustment HOT 2
- please fix paymentInstrument type by making it nullable HOT 4
- Improve Client Configuration Docs HOT 2
- ClientInterface is not respected. Unable to provide `www-authenticate` header in `requestOptions` HOT 1
- [BUG] Field 'sessionId' is not valid for CS2B83412EE1DAB13D HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adyen-node-api-library.