Giter Club home page Giter Club logo

Comments (7)

vkurlyan avatar vkurlyan commented on August 15, 2024 1

If module is undefined we will have excaption because it's undefined variable but not property. You need to change code to do it without excaption:

if (typeof module !== 'undefined' && module.exports)

from adyen-cse-web.

agudulin avatar agudulin commented on August 15, 2024

I've created corresponding PR for that: #17

from adyen-cse-web.

vkurlyan avatar vkurlyan commented on August 15, 2024

if (module && module.exports) {

this code leads to the exception in a browser because 'module' is undefined

from adyen-cse-web.

agudulin avatar agudulin commented on August 15, 2024

@vkurlyan no, it does not :)

the second condition will never be executed if the first one is falsy.

so if (undefined && undefined.exports) { ... } will never show the execption

from adyen-cse-web.

agudulin avatar agudulin commented on August 15, 2024

however the corresponding PR has been already merged
and this issue can be closed

from adyen-cse-web.

vkurlyan avatar vkurlyan commented on August 15, 2024

I added pull request #25

from adyen-cse-web.

agudulin avatar agudulin commented on August 15, 2024

@vkurlyan ah, I see, thanks!

from adyen-cse-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.