Deprecated Ingress API version about charts HOT 4 CLOSED

Thanks for the report. Could you put together a PR for this? I will merge and publish.

from charts.

I am happy to put a PR together but it would change your k8s dependency quite a bit - the networking.k8s.io/v1 api version is supported on k8s >1.16, currently you support >1.9. Do you still want me to go through with the PR?

from charts.

I think you could use a conditional like so and support multiple cluster versions:

{{- $kubeVersion := .Capabilities.KubeVersion.Version }}
{{- if semverCompare ">= 1.19.0-0" $kubeVersion }}
apiVersion: networking.k8s.io/v1
{{ else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }}
apiVersion: networking.k8s.io/v1beta1
{{ else }}
apiVersion: extensions/v1beta1
{{ end -}}

That seem okay?

from charts.

Hey @jbielick, I made those changes and my deployment seems to work fine - but I'm having issues trying to open a PR, I tried to go through the process described in the readme and run bin/package faktory but all the tests are failing. The tests also fail even when I clone the repo fresh and don't change anything.

from charts.