[Linux] Some mods in manifest cause a crash. about cmpdl HOT 17 CLOSED

Wow, Will fix this by 25/11/2022

from cmpdl.

My dude, the error is not on my end it is on cursepy's end.

from cmpdl.

I've raised an issue at OwenCochell/cursepy#13

from cmpdl.

Btw, here is a simpler reproducible code example:

from cursepy import CurseClient
from v import api_key

c = CurseClient(api_key)
addon = c.addon(400012) # Ex Nihilo: Sequentia

for file in addon.files():
    print(file.download_url)

# The output will only be None

from cmpdl.

Okay, there was another bug with a specific mod where the error actually showed their files, so I'll report that to them too.

from cmpdl.

@TwigGlenn4 use v2.5.0 as it contains optimizations and a temp fix for this issue

Also read the release notes 😉

from cmpdl.

This works great! My only suggestion would be to print a list of errored mods at the end so users know what they need to manually download without scrolling through all the output in a large modpack. Hostile Neural Networks (projectID 552574, fileID 4019567) still breaks somehow with the logo and needs to be manually removed, but that's a problem with cursepy and i've submitted an issue to them.

from cmpdl.

Ok, will work on it, please keep this issue open

from cmpdl.

This works great! My only suggestion would be to print a list of errored mods at the end so users know what they need to manually download without scrolling through all the output in a large modpack.
Hostile Neural Networks (projectID 552574, fileID 4019567) still breaks somehow with the logo and needs to be manually removed, but that's a problem with cursepy and i've submitted an issue to them.

Could you attach the logs please, I will try to look into it

from cmpdl.

Nevermind I found it OwenCochell/cursepy#14
Will submit a patch by 25/11/2022

from cmpdl.

@TwigGlenn4 as a temporary workaround while we wait for a patch, you can Download the Source.7z and change backend.py to use file.guess_download() its around line 198 and should look like this after the change.

if file.download_url is None:
    file.download_url = file.guess_download()
    #self.log(f"Mod is [b red]not downloadable[/] [b]{file.id}[/] [b]{mod.name}[/] due to API error")
    #self.log("See https://github.com/Advik-B/CMPDL/issues/25 for more info")
    continue

Also make sure in the requirements.txt the cursepy version is set to 2.2.0
i've tested it with ATM8 and so far it works

from cmpdl.

@TwigGlenn4 as a temporary workaround while we wait for a patch, you can Download the Source.7z and change backend.py to use file.guess_download() its around line 198 and should look like this after the change.

if file.download_url is None:
    file.download_url = file.guess_download()
    #self.log(f"Mod is [b red]not downloadable[/] [b]{file.id}[/] [b]{mod.name}[/] due to API error")
    #self.log("See https://github.com/Advik-B/CMPDL/issues/25 for more info")
    continue

Also make sure in the requirements.txt the cursepy version is set to 2.2.0 i've tested it with ATM8 and so far it works

@ArcadeArchie, you could also use the ZipApp.zip

from cmpdl.

Will do, when I get the chance.

from cmpdl.

@Advik-B i've tested it with the ZipApp.zip and ATM7 to the Sky, and it does work somewhat

• you need to delete the cursepy folder that ZipApp.zip ships with and pip install cursepy==2.2.0
• and with ATM7 to the Sky not all mods are correctly downloaded even with guess_download() see screenshot

from cmpdl.

Oh, will patch that later this month. (Because of my exams on monday)
Anyways, here is the sunday patch I promised 👉🏻 v2.5.5

from cmpdl.

@ArcadeArchie could you please create a new issue?

from cmpdl.

Closing the issue in favor of the patch
Please create a new issue so that it will be easy for me to track down

from cmpdl.