Automatic reload of regions with modified mesh-points about felupe HOT 4 CLOSED

If you rely on this feature, then please open a pull request. We can improve this in the future if necessary.

from felupe.

Hi @adtzlr , I'm not sure if my suggestion can solve this issue, but we can add a callback to the mesh.update method, so after updating the mesh the callback will be called internally; let's take a look:

def update(self, points=None, cells=None, cell_type=None, callback=None):
        "Update the cell and dimension attributes with a given cell array."

        if points is not None:
            self.points = points

        if cells is not None:
            self.cells = cells

        ...
        
        ############## - Added - ################
        if callable(callback):
            callback(self)
        #########################################  

And then, the

mesh.update(points=mesh.rotate(angle_deg=-90, axis=2).points)

# this is important!
region.reload(mesh)

is replaced with the;

mesh.update(points=mesh.rotate(angle_deg=-90, axis=2).points, callback=region.reload)

from felupe.

Hi, thanks! I was thinking about that too, i.e. to add an update-method to a region like region.update(mesh=None, element=None, quadrature=None). However, this could lead to problems with the subsequent usage of template classes like RegionHexahedron. Currently, all FElupe classes are more or less "stand alone concepts". Your approach wouldn't change that. I'm still not sure if I should add callbacks here and there in FElupe as I think they are not very "pythonic".

from felupe.

Hi, thanks! I was thinking about that too, i.e. to add an update-method to a region like region.update(mesh=None, element=None, quadrature=None). However, this could lead to problems with the subsequent usage of template classes like RegionHexahedron. Currently, all FElupe classes are more or less "stand alone concepts". Your approach wouldn't change that. I'm still not sure if I should add callbacks here and there in FElupe as I think they are not very "pythonic".

Okey then, I'm sure that there's no a just one solution👌🙂, it's a matter of time, hope this fixed.

from felupe.