Giter Club home page Giter Club logo

Comments (1)

adrianosela avatar adrianosela commented on September 24, 2024

This is a good point @Gaillard. I am unsure of what the best way to handle this issue is. Perhaps giving the very first ever "Get()" a random sleep so as to minimize the chance of simultaneous cert creation requests to LE.

However, it may not be that serious, here is why I don't think its too big of a deal:

Even if your first deployment of n replicas, where (n > LE rate limit = 5) fails one of the replicas/containers, at that point you will already have the last of the certs in store, and all successive deployments will succeed to pick up a cert from storage. This includes the replicas that died and restarted when they failed to get a cert directly from acme/autocert; as well as all new deployments.

In terms of security, it may not be great to generate multiple redundant certs and throw all but one away without revoking them.

I will try to think of a good way to handle this situation soon in the future. Thank you for bringing up the issue.

Since the issue does not break the current implementation for DynamoDB, I am tagging this issue as an enhancement.

If you would like to work on this, PRs are welcome.

from certcache.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.