Giter Club home page Giter Club logo

Comments (3)

AdamBrousseau avatar AdamBrousseau commented on August 21, 2024 1

There shouldn't be a need to specify a new config parameter if we already have one that appears to do what you are describing regarding specifying your own tests.

This feature is useful if you have an odd spec that does not follow the default. However for my use, all my specs run the same testing but that list does not match the Adopt default. I would therefore need to paste my list into every spec which is inconvenient. Moving that default list into defaults.json for example, would allow me to change it to my liking for all specs at once. Both for the Nightly and Weekly lists.

from ci-jenkins-pipelines.

AdamBrousseau avatar AdamBrousseau commented on August 21, 2024 1

Thanks, Morgan!

from ci-jenkins-pipelines.

M-Davies avatar M-Davies commented on August 21, 2024

Ref:
https://github.com/AdoptOpenJDK/ci-jenkins-pipelines/blob/bb2ada1e00694a18a00060d8ee37fb36b7f38a75/pipelines/build/common/build_base_file.groovy#L219-L223
and the test field of #data fields:

Name Required? Type
Description
test String
OR
Map<String, List>
Tests to run against the binary after the build has completed. A default tag indicates that you want to run whatever the default test nightly/release list is.

Otherwise, you can specify your own list for that paticular platform (not variant)

There shouldn't be a need to specify a new config parameter if we already have one that appears to do what you are describing regarding specifying your own tests.

I will also not necessarily want to follow changes made to ENABLE_TESTS

That however is something that should be moved into a config file. I will look into this

from ci-jenkins-pipelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.