Giter Club home page Giter Club logo

Comments (8)

snewcomer avatar snewcomer commented on June 13, 2024

Woah. Yes you are correct. That would definitely prevent you from upgrading. I'll see if I can look into it tomorrow.

from ember-infinity.

snewcomer avatar snewcomer commented on June 13, 2024

If this is a long outstanding bug, we may need to simply change the blueprint to generate a new filename. What do you think? It was a "breaking change" from the perspective of the framework when I introduced the templated infinity-loader in this addon for 2.1.0. I'm not sure of another solution....

from ember-infinity.

maartenparmentier avatar maartenparmentier commented on June 13, 2024

I think that's a valid idea and solution. 👍

from ember-infinity.

snewcomer avatar snewcomer commented on June 13, 2024

Hm. A slight nuisance with that this approach would require you to import and extend from the addon's infinity-loader.js class...We may have to suggest that approach in the README.

I'm also wondering if the errors is due to how we are exporting our template in app/. Will look into that next.

from ember-infinity.

brunoocasali avatar brunoocasali commented on June 13, 2024

Hey @snewcomer how can I do the approach you mentioned above? (I'm really interested in this fix, my build is broken too 💃)

from ember-infinity.

mk-conn avatar mk-conn commented on June 13, 2024

Hey @snewcomer how can I do the approach you mentioned above? (I'm really interested in this fix, my build is broken too 💃)

Yep, would be interested in that workaround too... :)

from ember-infinity.

snewcomer avatar snewcomer commented on June 13, 2024

@maartenparmentier I'm going to give #423 a try...I'm unsure that, if because it is exporting the template, that is is causing the build issues you are seeing. By removing it, it "may" help.

2.1.1

Lmk if it helps! I can reopen if it doesn't.

from ember-infinity.

maartenparmentier avatar maartenparmentier commented on June 13, 2024

@snewcomer It works! Thank you for this 🙏 👍

from ember-infinity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.