Action.skip_if_no about light-service HOT 4 CLOSED

Actually, it might be enough to have something like Action.options :milk, so that we have access to ctx.milk w/o adding it to Action.expects:

class AddsMilk
  include LightService::Action
  expects :cup
  options :milk # like expects, but doesn't raise errors if missing

  executed do |ctx|
      next ctx unless ctx.milk
      ctx.cup.add ctx.milk
  end
end

from light-service.

@padi: Let me try to summerize what I read above.

1. You have 4 actions the organizer will execute
2. Since you are expecting milk to be in the context for the 3rd action, the previous action has to add it to the context in order to avoid the ExpectedKeyNotInContextError exception
3. You suggest making milk an optional attribute in the context so your 2nd (or an earlier) action does not have to set it explicitly nil

If all the statments above are correct, what would the context set the optional attributes? Just nil?

I have not bumped into this scenario just yet, but I could see this being a problem if you want to reuse actions with different organizers using different contexts. We try to make our actions so small, that if something does not fit in it, we just create another action for it. You guys might be pushing this further than what we use it for.

It would be helpful if you could send a PR with a new spec in it, that better demonstrates the problem. A test should tell us the whole story, right?

from light-service.

@padi: Any update on this? What should I do with this issue?

from light-service.

I don't remember the particular scenario that prompted me to post this PR. I'll close this issue for now until we encounter a really painful scenario that absolutely requires something like this.

from light-service.