Comments (2)
Good point. That regexp is too generic, indeed. The idea was just to strip out the ones on the initial svg tag so that you can essentially adjust the viewport of the SVG via CSS if needed (i.e. to align several icon sizes on a page when the original icons have different sizes)
from aem-boilerplate.
I think this is no longer an issue given the change icons are handled.
from aem-boilerplate.
Related Issues (20)
- --overlay-color is not defined
- Icons that are linked are flagged by page speed insights that "Links do not have discernible names" HOT 1
- helix-header-footer-issue HOT 1
- Lower entropy for RUM IDs and Timestamps
- [hlx5] Move lib-franklin.js to aem.js HOT 1
- [hlx5] Rename repo to aem-boilerplate HOT 1
- decorateIcons() function accessibility improvement when hyperlinked HOT 1
- search.svg is missing HOT 1
- PSI test should be run against .live and not .page HOT 1
- Add a check of the hash of aem.js as part of the git PR workflow? HOT 1
- Add codeBasePath reference in header and footer blocks HOT 2
- Update to Icon SVG Handling created Accessibility regression
- I'm encountering difficulties connecting my project to SharePoint. Could you provide a comprehensive, step-by-step guide or recommend professional video resources to assist me with this integration? I believe detailed guidance or visual references would significantly aid in establishing the connection between my project and SharePoint. HOT 1
- Renovate configuration is not fit for the AEM code sync bot
- Cleanup GitHub workflow is not running HOT 1
- Repair semantic-release or remove completely
- CreateOptimizeImage should support FQDN cross-origin sources
- In very rare cases, header and footer loading can result in a FOUC
- Remove Lint Rule: no-use-before-define HOT 1
- Cleanup workflow not working on creating repo on using template
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aem-boilerplate.