Giter Club home page Giter Club logo

Comments (16)

benkiel avatar benkiel commented on July 22, 2024

Adrien,

As far as I know/remember, featureNames is just supported for ssXX.

Best,
Ben Kiel

from afdko.

kenlunde avatar kenlunde commented on July 22, 2024

What is stated in the OpenTypeFeatureFileSpecification.html file agrees.

from afdko.

adrientetar avatar adrientetar commented on July 22, 2024
  • The OpenType registry mandates a name field. Is it not supported by the AFDKO? If so, does Adobe intend to add support for it?
  • Secondly, and if this name field is not supported for this feature, why doesn't the compiler error in this case?

from afdko.

kenlunde avatar kenlunde commented on July 22, 2024

What does the "spot -tname" output look like, in terms of showing these featureNames strings?

from afdko.

benkiel avatar benkiel commented on July 22, 2024

It is worth pointing out, that currently, nothing supports names for ssXX. I don’t know what support is for cvXX.

from afdko.

kenlunde avatar kenlunde commented on July 22, 2024

After consulting the OpenType Specification, it is also worth pointing out that a featureNames string is not required for either 'cvXX' nor 'ssXX' GSUB features.

from afdko.

adrientetar avatar adrientetar commented on July 22, 2024

Ken,

I pasted that info here: https://gist.github.com/adrientetar/8123f8b015d7f685f7ad, I notice the first lines "Unknown tag with FeatureParam".

You are right with these being optional, I went too strongly worded when I said "mandates".

from afdko.

kenlunde avatar kenlunde commented on July 22, 2024

Please do the same for the 'name' table, because that is where these strings are actually specified. Though, the first few lines of the "spot -tGSUB" output suggest that something went awry.

from afdko.

adrientetar avatar adrientetar commented on July 22, 2024

Ken,

Here it is: https://gist.github.com/adrientetar/fc577a75876d9fde6add
This one does not look faulty at first glance.

Ben,

I know, right? I'm not going to cut down my software because there is no end-user support. And features support is a chain just like in web development – as much as end-user softwares have to support features to get them to work, designers have to support them too, and if no one uses them or ask for them things are not going to change.

If support for descriptive names in user software lands in fifty years from now, users will get an immediate added value, without needing any upgrade. That isn't bad in my opinion.

from afdko.

readroberts avatar readroberts commented on July 22, 2024

I do agree that it is a bug that makeotf does not complain about using the 'featureNames' tag with features other than the stylistic alternates field. You will see in in the definition of the FeaturesParam field of the Features table that it is set to NULL except for specific features that provide a definition for it's use, and the use of the field must be provided explicitly and separately by each feature the does use it. Currently a definition of use is provided only for the GPOS 'size' feature, and the GSUB stylistic alternates feature.

from afdko.

benkiel avatar benkiel commented on July 22, 2024

Adrien,

I do not disagree with your stance at all, the eggs need laying for the chickens to be born.

Ben

from afdko.

adrientetar avatar adrientetar commented on July 22, 2024

Read,

Interesting. Can you point me to these feature definitions?

Ben,

Cheers.

from afdko.

readroberts avatar readroberts commented on July 22, 2024

OpenType spec at:
http://www.microsoft.com/typography/otspec/
Follow link to "OpenType Layout Tag Registry":
http://www.microsoft.com/typography/otspec/ttoreg.htm
Follow link to 'feature tags":
http://www.microsoft.com/typography/otspec/featuretags.htm
Search document for "FeatureParams".

from afdko.

adrientetar avatar adrientetar commented on July 22, 2024

Ah, I thought that by definitions you meant code in the AFDKO.

Currently a definition of use is provided only for the GPOS 'size' feature, and the GSUB stylistic alternates feature.

Well, as I see it cvXX has a FeatureParams definition in the otspec that says how the various strings are used for a UI, what makes it so that it has no definition of use?

from afdko.

readroberts avatar readroberts commented on July 22, 2024

I see that you are correct. The page I was searching was limited to tags in the range p-t, which is why I missed the cvXX definition of FeatureParams. This is definitely a bug in makeotf. The FeatureFile 'featureName' tag is specific to ssXX features. The cvXX FeatureParams field points to a data block with quite a different structure, and different fields; this is why 'ttx' crashes - it is expecting the amount of data associated with the cvXX feature, and is being handed the data block for the ssXX feature instead. makeotf does not yet support building the set of fields associated with the FeatureParams for the cvXX feature.

from afdko.

readroberts avatar readroberts commented on July 22, 2024

The latest version of makeotf does support character variation features.

from afdko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.