Giter Club home page Giter Club logo

Comments (7)

ADmad avatar ADmad commented on July 30, 2024 1

With debug on the 500 is expected since I am directly throwing the exception generated by Jwt::decode() for easy debugging. With debug off you will get a 401.

from cakephp-jwt-auth.

ADmad avatar ADmad commented on July 30, 2024

Are you checking with debug on or off? With debug off you should get a 401 response code.

from cakephp-jwt-auth.

eymen-elkum avatar eymen-elkum commented on July 30, 2024

the debug is on

from cakephp-jwt-auth.

eymen-elkum avatar eymen-elkum commented on July 30, 2024

Up to me 500 was not expected, and the message passed to the 401 was enough.
we may pass some more information about the original exception to the auth exception for debug issues

from cakephp-jwt-auth.

eymen-elkum avatar eymen-elkum commented on July 30, 2024

I now understand the reason that made you directly throwing the exception generated by Jwt::decode() when debug is on.
it is needed when you build this plugin and test it but not when someone using it in his project.

from cakephp-jwt-auth.

ADmad avatar ADmad commented on July 30, 2024

No it was not for plugin development, it's to make debugging easier for the app developer as Jwt::decode() can throw multiple types of exceptions. This behavior is similar to how for e.g. you would get a MissingController exception with debug on but that would be turned in into a NotFoundException with debug off.

I am not keen on changing this behavior. As I stated earlier with debug off you will always get an UnauthorizedException with 401 status code if authentication fails for any reason.

from cakephp-jwt-auth.

eymen-elkum avatar eymen-elkum commented on July 30, 2024

Ok
Then I will do it in my project :)

from cakephp-jwt-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.