Giter Club home page Giter Club logo

Comments (2)

cyril-sf avatar cyril-sf commented on July 23, 2024

That's a good idea.

cc @LydiaBarnes @joelshawaddepar @hanakimis

from ember-charts.

LydiaBarnes avatar LydiaBarnes commented on July 23, 2024

I 100% agree. I personally don't like the way this was done, its a bad habit we started. I wasn't here when when this was set up back in the day, but from what I can tell (based on other projects) this was actually done purposefully. That was our easy way of tweaking Bootstrap to look how we wanted, thanks to LESS's weird variable scope.

If we do rename these variables, we will need to check to make sure we don't cause changes elsewhere (not necessarily charts itself, but other projects that use it). Since for example, @label-color is used elsewhere in Bootstrap and would no longer be updated to our new color, which we may or may not have been relying on.

from ember-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.