simulator build fails with multiple defined symbols on Fedora 22 for 2015.1 about epiphany-sdk HOT 7 CLOSED

forgot to specify the gcc version:

$ gcc --version
gcc (GCC) 5.1.1 20150618 (Red Hat 5.1.1-4)

from epiphany-sdk.

I think I see the problem. Here's an example. (All paths relative to unisrc-2015.1/sim)

The code is using a technique to inline functions if certain variables are defined. common/sim-arange.h shows this with

#ifdef HAVE_INLINE
#ifdef SIM_ARANGE_C
#define SIM_ARANGE_INLINE INLINE
#else
#define SIM_ARANGE_INLINE EXTERN_INLINE
#endif
#include "sim-arange.c"
#else
#define SIM_ARANGE_INLINE
#endif
#define SIM_ARANGE_C_INCLUDED

It appears that the problem with this approach is that it's possible for GCC to decide not to inline a function. If this happens, then that function is copied int every C file that includes sim-basics.h leading to it being compiled everywhere but not inlined, resulting in multiple symbol definitions that are discovered by ld, breaking the build.

I don't know what the solution is.

from epiphany-sdk.

My analysis was in error. The problem is that the meaning of 'extern inline' is different in gnu89 than it is in gnu11 and gcc 5 defaults to gnu11

https://gcc.gnu.org/gcc-5/porting_to.html describes the situation.

The solution appears to be to change the definition of FOO_INLINE to EXTERN_INLINE in foo.h and to compile with -std=gnu89

from epiphany-sdk.

I have the same problem with gcc 5.2.0. Any solutions yet?

from epiphany-sdk.

@Shadowigor
Can you please try again. Should be fixed in:
8335158

You need to cd into sdk and do a git pull to get the fix

// Ola

from epiphany-sdk.

Thank you! It works now.

from epiphany-sdk.

closing as it seems fixed.

from epiphany-sdk.