Giter Club home page Giter Club logo

Comments (9)

adamsoffer avatar adamsoffer commented on August 20, 2024 1

@wayne530 - Looks like someone got to the bottom of this a couple days ago on the next.js apollo example :) vercel/next.js#8917

I'll look into implementing the fix here as well.

from next-apollo.

colinappnovation avatar colinappnovation commented on August 20, 2024

Note: Do not be alarmed that you see two renders being executed. Apollo recursively traverses the React render tree looking for Apollo query components. When it has done that, it fetches all these queries and then passes the result to a cache. This cache is then used to render the data on the server side (another React render). https://www.apollographql.com/docs/react/api/react-ssr/#getdatafromtree

from next-apollo.

wayne530 avatar wayne530 commented on August 20, 2024

@colinappnovation thanks for the reply. To be clear, I’m not seeing multiple different queries, I’m seeing exactly two identical graphql queries on a page that in theory should only execute one. By adding a console.log, I verified the server is executing one and the client is executing one. I would expect that if the page is rendered server-side, I would only see a single query by the server, and similarly, if the page is rendered client side, I’d see a single query by the client. Seeing both feels unexpected and certainly could have unintended consequences for mutations.

from next-apollo.

wayne530 avatar wayne530 commented on August 20, 2024

@adamsoffer I'm wondering if you might be able to comment on the "expectedness" of what I'm seeing? Do you see the same thing with your canonical example?

from next-apollo.

wayne530 avatar wayne530 commented on August 20, 2024

That's awesome news, thanks @adamsoffer for the update!

from next-apollo.

wayne530 avatar wayne530 commented on August 20, 2024

Hey @adamsoffer, just checking to see if you have any updates on this?

from next-apollo.

chandan-reddy-k avatar chandan-reddy-k commented on August 20, 2024

@adamsoffer @wayne530 was this issue resolved ? I face the same issue.

from next-apollo.

wayne530 avatar wayne530 commented on August 20, 2024

@chandan-reddy-k unfortunately, I don’t think it has yet.

from next-apollo.

adamsoffer avatar adamsoffer commented on August 20, 2024

This should be fixed in v4.0.0

from next-apollo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.