Giter Club home page Giter Club logo

Comments (3)

adamralph avatar adamralph commented on June 30, 2024

@gokanil I added a test for this and it succeeds — https://github.com/adamralph/simple-exec/pull/581/files

from simple-exec.

adamralph avatar adamralph commented on June 30, 2024

@gokanil I've merged the test and, on that basis, I'm closing this.

from simple-exec.

adamralph avatar adamralph commented on June 30, 2024

@gokanil to double check, I ran a test on a Windows machine, and I figured out the problem. It is unrelated to createNoWindow. The problem is that when you run CMD and then provide the name of some other executable, a process is created for CMD, and then a child process is creating for the executable. When you cancel the token, the parent process for CMD is killed, but the child process for the executable is left running. This is expected behaviour, because in .NET 7 and earlier there was no way to kill a child process using System.Diagnostics. In .NET 8 however, it is possible, and an issue has already been raised to take advantage of that in SimpleExec.

If you want to know when a version of SimpleExec will available that exhibits the behaviour you require, then I suggest you watch #541.

from simple-exec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.