Giter Club home page Giter Club logo

Comments (7)

adambutler avatar adambutler commented on May 27, 2024 1

Fixed by #10

from diy.

stuartpb avatar stuartpb commented on May 27, 2024

I think the first test should be assert($ === document);

from diy.

duhruh avatar duhruh commented on May 27, 2024

You mean the only test

from diy.

stuartpb avatar stuartpb commented on May 27, 2024

You can also do assert($ == window.document); assert($ instanceof HTMLDocument);...

from diy.

stuartpb avatar stuartpb commented on May 27, 2024

not to mention battalions of functional test cases

if an assertion fails in a functional test case it might even uncover a bug in the upstream implementation, maybe, although there should definitely be a fine-toothed review combing over the entire codebase locally before assuming something like that

from diy.

stuartpb avatar stuartpb commented on May 27, 2024

that would be crazy, import a bunch of known failing func test cases from phantom/casper/blink to make var $ = document; have a pass rate of like 0.4%

variable assignment is so unreliable, guys, just look at these test scores

from diy.

stuartpb avatar stuartpb commented on May 27, 2024

hahaha we're already getting these: #7

from diy.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.