JETSON_NANO is capitalized about adafruit_python_platformdetect HOT 6 CLOSED

All boards are uppercase. Currently pulseio is looking at these properties: https://github.com/adafruit/Adafruit_Python_PlatformDetect/blob/master/adafruit_platformdetect/board.py#L462-L622

from adafruit_python_platformdetect.

I added this code to pulseio.py on a development versions, all of the names are lower case in the file. however the only thing that worked for the jetson was this capital line:

elif detector.board.JETSON_NANO:

from adafruit_python_platformdetect.

Ping. Can you please explain why all the elif in the blinka pulseio.py is lower case if detector is supposed to be capitalized? I'd like to finish the pulseio implementation

from adafruit_python_platformdetect.

I added this code to pulseio.py on a development versions, all of the names are lower case in the file. however the only thing that worked for the jetson was this capital line:

elif detector.board.JETSON_NANO:

This will always be true, because it's a constant that is "truthy":

Can you please explain why all the elif in the blinka pulseio.py is lower case if detector is supposed to be capitalized

It is just a name for the string. In detector/constants/boards.py, there is this: JETSON_NANO = "JETSON_NANO". The if in blinka pulseio.py is actually checking whether a certain kind of board is present. For Jetson, you want to check:

elif detector.board.any_jetson_board:
...

That will return true if it's a Jetson board.

from adafruit_python_platformdetect.

@dhalbert explained this well. You may also consider using something like:

if detector.board.id == detector.board.JETSON_NANO:

from adafruit_python_platformdetect.

Closing because making this change would break a lot of other stuff.

from adafruit_python_platformdetect.