No seamless workaround for missing descriptor support about adafruit_blinka HOT 8 CLOSED

I don't think we should change our libraries for this. Data descriptors simplify the drivers a bunch.

Would you mind opening an issue in MicroPython's repo for them to enable it? They should be interested in having our libraries compatible. I can follow up on it as well.

from adafruit_blinka.

I'm taking Damien's inline comment...

// This costs some code size and makes all load attrs and store attrs slow

...and the statements at https://github.com/micropython/micropython/wiki/Differences to mean they have already decided to exclude it by default, so I think the debate has been had once and settled in favour of performance and resource-efficiency, given there are always substitute language structures.

Do you think we should open it as an issue in any case to record the decision?

BTW I am not proposing that libraries are changed. Rather that people running on Micropython would have to run a post-load monkey-patching operation to switch descriptors for properties on classes where they are found. This would be after import and before use, and not require any code-changes to the module source. Not sure when and how this strategy might fail, though. E.g. are frozen-modules any different in terms of dynamic manipulation. It might be a crazy thought until I've worked through it.

from adafruit_blinka.

I think opening an issue is still worth while. That decision was made before we had 50+ libraries. :-) Determining the code size increase would be a good piece of info to have too.

What would they switch the descriptors to? Properties are implemented using data descriptors.

Frozen modules won't be an issue because we're assuming its a MicroPython build. mpy files are identical to py files after load.

from adafruit_blinka.

What would they switch the descriptors to? Properties are implemented using data descriptors.

I'm just picking up on the https://github.com/micropython/micropython/wiki/Differences comment;
"So far, we were able to implement all native Python features (like properties) without explicit descriptors."

If it's not been covered again recently I'll open an issue.

from adafruit_blinka.

Ancient discussion of strategy for implementing properties at micropython/micropython#474 and
https://github.com/micropython/micropython/blob/6e675c1baaf0de0d56a2345376d6b5600bfab3aa/py/mpconfig.h shows properties configured by default across all current builds, so the property patching strategy should be feasible if no official descriptor support (or while waiting for it).

from adafruit_blinka.

You can find the issue on enabling descriptor support on official images as recently raised at https://github.com/micropython/micropython/issues?utf8=%E2%9C%93&q=is%3Aissue+descriptor

from adafruit_blinka.

Upstream issue is micropython/micropython#3644 and I've subscribed to it. Thanks!

from adafruit_blinka.

Closing as it appears descriptors were added.

from adafruit_blinka.