Comments (16)
AlbanMinassian
commented on May 4, 2024
info only : https://docs.rs/tokio-rustls/0.5.0/tokio_rustls
from actix-web.
fafhrd91
commented on May 4, 2024
I can not add rustls support at the moment. all packages needs to depend on same ring package
from actix-web.
mssun
commented on May 4, 2024
all packages needs to depend on same ring package
What does it mean? I also hope to see rustls support. I understand rustls depends on ring internally.
from actix-web.
fafhrd91
commented on May 4, 2024
rustls depends on ring ^0.13.0-alpha
cookie depends on ring 0.12.1
I think it is not possible to compile two different ring dependency
from actix-web.
mssun
commented on May 4, 2024
Correct me if I'm wrong. I remember that cargo can compile with two different version crates. But probably have two copies of library code?
Also, the master cookie support ring ^0.13.0-alpha in Jan. https://github.com/alexcrichton/cookie-rs/blob/master/Cargo.toml#L20
from actix-web.
fafhrd91
commented on May 4, 2024
cargo can, but ring uses asm which is the problem. I don't think alpha dependency is good idea
from actix-web.
mssun
commented on May 4, 2024
I see. Thank you so much!
from actix-web.
DemiMarie
commented on May 4, 2024
May I ask why?
RustTLS is already used in production.
…On Thu, Jun 7, 2018, 2:28 PM Nikolay Kim ***@***.***> wrote:
cargo can, but ring uses asm which is the problem. I don't think alpha
dependency is good idea
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#36 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGGWB_sE_qJWemNfMbEXwTg2lUUTAd2wks5t6XDWgaJpZM4RSS1f>
.
from actix-web.
fafhrd91
commented on May 4, 2024
You can use anything in production. But if library is ready for production why it is not released as stable version.
…Sent from my iPhone
On Jun 7, 2018, at 12:49 PM, Demi Marie Obenour ***@***.***> wrote:
May I ask why?
RustTLS is already used in production.
On Thu, Jun 7, 2018, 2:28 PM Nikolay Kim ***@***.***> wrote:
> cargo can, but ring uses asm which is the problem. I don't think alpha
> dependency is good idea
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#36 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AGGWB_sE_qJWemNfMbEXwTg2lUUTAd2wks5t6XDWgaJpZM4RSS1f>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
from actix-web.
DemiMarie
commented on May 4, 2024
Futures is not stable either.
…On Thu, Jun 7, 2018, 3:51 PM Nikolay Kim ***@***.***> wrote:
You can use anything in production. But if library is ready for production
why it is not released as stable version.
Sent from my iPhone
> On Jun 7, 2018, at 12:49 PM, Demi Marie Obenour <
***@***.***> wrote:
>
> May I ask why?
>
> RustTLS is already used in production.
>
> On Thu, Jun 7, 2018, 2:28 PM Nikolay Kim ***@***.***>
wrote:
>
> > cargo can, but ring uses asm which is the problem. I don't think alpha
> > dependency is good idea
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <#36 (comment)>,
or mute
> > the thread
> > <
https://github.com/notifications/unsubscribe-auth/AGGWB_sE_qJWemNfMbEXwTg2lUUTAd2wks5t6XDWgaJpZM4RSS1f
>
> > .
> >
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#36 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGGWB0spr0maQB0b-71vqSvbOrJTGl1zks5t6YQ9gaJpZM4RSS1f>
.
from actix-web.
fafhrd91
commented on May 4, 2024
choice is yours.
as a maintainer of the actix project i chose not to integrate with rustls at this stage.
from actix-web.
Tommoa
commented on May 4, 2024
One option to solve the issue of differing ring dependencies is to use rustls 0.11 and tokio-rustls 0.4. Both of them use ring 0.12.1.
from actix-web.
hayd
commented on May 4, 2024
Multiple ring versions should work together after briansmith/ring#619 is merged.
from actix-web.
ctz
commented on May 4, 2024
This should now be unblocked by https://crates.io/crates/rustls/0.13.0 which depends on the latest ring release without the single-version constraint. Please do let me know if I can help 👍
from actix-web.
DoumanAsh
commented on May 4, 2024
We do have cookie that uses ring 0.12 also though
Hopefully after 0.13 stable ring we get new version of cookie rwf2/cookie-rs#106
from actix-web.
fafhrd91
commented on May 4, 2024
fixed by #427
from actix-web.
Related Issues (20)
- Why is the code below why version 4 cannot access httpserver, but version 3 can? HOT 1
- awc CONNECT method support
- add Proxy-Connection header HOT 3
- Filter out completely impossible characters.
- Add macro for route handler accepting all HTTP methods HOT 13
- Compilation fails when using the latest version of rustls HOT 5
- Add pattern syntax for optional trailing slash
- [How to] Middleware `Response body` manipulation.
- Add support to be able to test the route tree using `match_pattern` and `match_name`. HOT 2
- Connecting to the database from an external network causes a spike in connections HOT 1
- actix-http: Compilation fails HOT 1
- Err(NoWebsocketUpgrade) HOT 1
- 在 c++开发中，使用ws进行请求。会因为路径上有中文而报错，In c++ development, using ws for requests will result in an error due to Chinese characters in the path. HOT 1
- 在 c++开发中，使用ws进行请求。会因为路径上有中文而报错，In c++ development, using ws for requests will result in an error due to Chinese characters in the path. HOT 1
- actix-web doesn't compile with rustls 0.23.1 HOT 3
- target mips-unknown-linux-musl compilation failed
- Unexpected routing HOT 1
- Seems like web::Json can't deserilize json with nested keys as payload inside requests into rust structs
- Unable to get app_data information in middleware HOT 1
- match_pattern/match_info/match_name may return incorrect values when using route guards
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actix-web.