Comments (4)
NicolasMassart
commented on June 18, 2024
12
Having it running from pull-request would be awesome as it would enable to host previews of the site changes in pages directly.
(ideally in a subfolder like https://user.github.io/project/pull-request/123/)
from deploy-pages.
yoannchaudet
commented on June 18, 2024
3
@feryardiant Thank you for opening this. We will correct the documentation. We have decided to have the starter workflows only trigger on the default branch and not track pull requests at the moment (e.g. here).
from deploy-pages.
feryardiant
commented on June 18, 2024
1
Apparently it still needs to have if: github.event_name == 'push' to make it skipped on pull-request.
deploy:
runs-on: ubuntu-latest
if: github.event_name == 'push'
needs: build
from deploy-pages.
yoannchaudet
commented on June 18, 2024
Well I am late but the documentation change was merged a while ago!
@NicolasMassart One day!
from deploy-pages.
Related Issues (20)
- Failing to fetch artifact metadata since 4.0.0 HOT 8
- Bump to V4 broke the deploy step HOT 9
- Remove requirement for `actions: read` permission HOT 1
- Unhelpful Error HOT 5
- Page Deployment Failing Periodically with Timeouts since Upgrade to v4 HOT 1
- Getting "Fetching artifact metadata failed." HOT 3
- Confusing error when trying to deploy Rust docs HOT 6
- CNAME file doesn't work to set custom domain
- Error: No artifacts named "github-pages" were found for this workflow run. HOT 5
- Deploy to another repository HOT 2
- GitHub Enterprise Server 3.11.5 compatibility HOT 6
- Deployment protection rules seem to be ignored HOT 1
- 502 error on github enterprise HOT 3
- More clarity on id-token: write HOT 11
- Artifact could not be deployed; no symlinks or hard links, small size HOT 1
- When the preview feature will be available HOT 1
- Allow deploy by artifact_id
- Problem in page deployment with vuejs vite to github page HOT 8
- Value 'github-pages' is not valid HOT 5
- Astro Site: Please ensure the content does not contain any hard links, symlinks and total size is less than 10GB HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deploy-pages.