Giter Club home page Giter Club logo

Comments (4)

JamesMGreene avatar JamesMGreene commented on June 18, 2024 2

Yeah, looks like that would do it. 😓

Suggested remediation:

  • Publish a new v1.x to "revert" that for folks referencing @v1
  • Re-release the change in v1.2.7 as v2.0.0 to make these distinctions cleaner
  • Update our internal dynamic workflow to use @v2 after that
  • Update the Pages starter workflows to use @v2, those should get pushed into the next GHES release's included starter workflows

from deploy-pages.

yoannchaudet avatar yoannchaudet commented on June 18, 2024 1

@jedla01 Sorry for that, I don't think that was our intention to break GHES.

@JamesMGreene @TooManyBees Could it be related to the change on the non-documented API?

from deploy-pages.

jedla01 avatar jedla01 commented on June 18, 2024 1

@jedla01 Thanks for this speedy report! We've published a [v1.2.8 release](https://github.com/actions/deploy-pages/releases/v1.2.8, as well as updating the v1 tag, to revert the breaking change in v1.2.7. 🙇🏻

Please let us know if that doesn't resolve your issue for some reason. 👍🏻

Thank you for such fast response and fix.

from deploy-pages.

JamesMGreene avatar JamesMGreene commented on June 18, 2024

@jedla01 Thanks for this speedy report! We've published a v1.2.8 release, as well as updating the v1 tag, to revert the breaking change in v1.2.7. 🙇🏻

Please let us know if that doesn't resolve your issue for some reason. 👍🏻

from deploy-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.