Giter Club home page Giter Club logo

Comments (2)

febuiles avatar febuiles commented on June 11, 2024

Hi @Gomer05. Thank you for the report. I have been able to reproduce it. Here's the failing log: https://github.com/future-funk/studious-giggle/actions/runs/4341088504/jobs/7580269884. I'll take a look at the soon.

Reproduction steps

I created a new repo. Its config file points to future-funk/miniature-waddle , the repo containing the actual configuration.

Expected behavior

The output of the run containing fail-on-severity: critical, the value specified in the external config.

Current behavior
We're outputting (and scanning) the action's default values (fail-on-severity: low).

from dependency-review-action.

febuiles avatar febuiles commented on June 11, 2024

@Gomer05 This should be fixed now in the main branch, and will make it to the next release, thanks again for the report!

If you want to test it works, you can replace the v3 for main in your workflow file, e.g.

        uses: actions/dependency-review-action@main

Something to note: The documentation was updated with some mistakes in another PR. I've changed it back, it but it's not super clear so here it goes again: key names in external config files should use underscores (_), not dashes (-). This means that the external configuration file keys should read like fail_on_severity, not fail-on-severity. I'll get back to fixing this in another PR (unless you want to open one first! 😅)

from dependency-review-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.