Comments (2)
Hi @Gomer05. Thank you for the report. I have been able to reproduce it. Here's the failing log: https://github.com/future-funk/studious-giggle/actions/runs/4341088504/jobs/7580269884. I'll take a look at the soon.
Reproduction steps
I created a new repo. Its config file points to future-funk/miniature-waddle , the repo containing the actual configuration.
Expected behavior
The output of the run containing fail-on-severity: critical
, the value specified in the external config.
Current behavior
We're outputting (and scanning) the action's default values (fail-on-severity: low
).
from dependency-review-action.
@Gomer05 This should be fixed now in the main
branch, and will make it to the next release, thanks again for the report!
If you want to test it works, you can replace the v3
for main
in your workflow file, e.g.
uses: actions/dependency-review-action@main
Something to note: The documentation was updated with some mistakes in another PR. I've changed it back, it but it's not super clear so here it goes again: key names in external config files should use underscores (_
), not dashes (-
). This means that the external configuration file keys should read like fail_on_severity
, not fail-on-severity
. I'll get back to fixing this in another PR (unless you want to open one first! 😅)
from dependency-review-action.
Related Issues (20)
- Add Scopes to Scanned Manifest Files inventory
- Blocking issues (should block but does not) HOT 5
- Add list of resolved vulnerabilities to the PR Comment / Logs
- Invalid URL for OpenSSF Scorecard Package HOT 3
- Create a PR check for default values in action.yml
- Bug: Some repos get error "fetch failed" when fetching v4.2.3 HOT 3
- Action fails to decorate PR when text is too long HOT 2
- Deny Packages Icon should be Red X (not a yellow warning) HOT 3
- Feature Request: Block on unknown licenses HOT 1
- `warn_only` Does Not Apply When Using a Deny List HOT 1
- error "fetch failed" with v4.2.5 HOT 3
- Scorecard table URLs include duplicate https:// HOT 3
- MIT is an invalid SPDX license identifier? HOT 2
- Question: Is this action limited to revisions on the _default_ branch only? HOT 2
- Conflict between vulnerabilities in scorecard vs check
- v4.3.0 Causing PURL Processing Errors HOT 6
- Allow this action to run on branch HOT 4
- Latest release breaks dependabot HOT 3
- Configuring allow-dependencies-licenses fails the action HOT 3
- Error :- Purl String argument is required . HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-review-action.