Giter Club home page Giter Club logo

Comments (5)

febuiles avatar febuiles commented on June 4, 2024 1

@jeffpaul The Action currently only supports config file inside the same repo. I expect support for org-wide config files to land soon.

from dependency-review-action.

jeffpaul avatar jeffpaul commented on June 4, 2024

@febuiles @cnagadya thanks for the great work on v3 adding the external config file, I'm very excited to use this across our org. Our file is not in the main repo folder (see https://github.com/10up/.github/blob/trunk/.github/dependency-review-config.yml) and attempts to reference a folder structure in the config-file param doesn't seem to work (see https://github.com/10up/insert-special-characters/pull/164/files). Perhaps I've not yet tried the "right" way to call a config file nested within an external repo?

from dependency-review-action.

febuiles avatar febuiles commented on June 4, 2024

Hi @jeffpaul, thanks for bringing this up, it's a good question. The current error text is misleading and your config file is getting read.

Because the external config file is a YAML file, we expect to find a list of licenses with the regular YAML format (lines with dashes, like this) (I tested this file as an external config and it works, hope it does for you too)

Since your example is in a single line, YAML will parse the entire line as a single license and then the SPDX parser will raise an error that this is an invalid license expression. Because of the way we handle errors, you end up getting an error for the config file fetching process, while it should actually complain about license parsing. I'll create a new PR to address this!

from dependency-review-action.

febuiles avatar febuiles commented on June 4, 2024

@jeffpaul There's actually more to this here, thanks for bringing it up! The previous point of using a YAML list should still work though.

from dependency-review-action.

jeffpaul avatar jeffpaul commented on June 4, 2024

Awesome, that example in the future-funk repo is super helpful, many thanks!

from dependency-review-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.