Comments (6)
febuiles
commented on June 5, 2024
@jackpie1206 Thanks such a complete bug report 🙇.
The API the Action uses to fetch the vulnerability and license info has different data from the GitHub Licenses API that you linked above.
There is a draft PR to use the GitHub License information as a fallback, it's just missing some tests before getting merged! You can see how it fixes the issue you reported in this sample worfklow run: https://github.com/future-funk/turbo-couscous/actions/runs/3233979525/jobs/5296523454.
from dependency-review-action.
jackpie1206
commented on June 5, 2024
@febuiles That looks promising! Question, after the PR gets merged, how long does it take for a new minor or patch release (I assume it won't be a major release)? Thanks.
from dependency-review-action.
febuiles
commented on June 5, 2024
@jackpie1206 for these bug fixes we cut new releases instantly.
Help with the PR is always welcome if you are familiar or want to learn TypeScript/GitHub Actions!
from dependency-review-action.
cnagadya
commented on June 5, 2024
@jackpie1206 this should be resolved in the v2.5.0 release
from dependency-review-action.
jackpie1206
commented on June 5, 2024
@febuiles @cnagadya Thanks for fixing this. Question, will the major version tag "v2" also get updated to point to v2.5.0 (or later)?
from dependency-review-action.
febuiles
commented on June 5, 2024
@jackpie1206 thanks a ton for the callout, it's been updated already!
from dependency-review-action.
Related Issues (20)
- Add list of resolved vulnerabilities to the PR Comment / Logs
- Invalid URL for OpenSSF Scorecard Package HOT 3
- Create a PR check for default values in action.yml
- Bug: Some repos get error "fetch failed" when fetching v4.2.3 HOT 3
- Action fails to decorate PR when text is too long HOT 2
- Deny Packages Icon should be Red X (not a yellow warning) HOT 3
- Feature Request: Block on unknown licenses HOT 1
- `warn_only` Does Not Apply When Using a Deny List HOT 1
- error "fetch failed" with v4.2.5 HOT 2
- Scorecard table URLs include duplicate https:// HOT 3
- MIT is an invalid SPDX license identifier? HOT 2
- Question: Is this action limited to revisions on the _default_ branch only? HOT 2
- Conflict between vulnerabilities in scorecard vs check
- v4.3.0 Causing PURL Processing Errors HOT 6
- Allow this action to run on branch HOT 4
- Latest release breaks dependabot HOT 3
- Configuring allow-dependencies-licenses fails the action HOT 3
- Error :- Purl String argument is required . HOT 4
- Adding a license in 'allow-dependencies-licenses' does not prevent it from being populated in "invalid-license-changes" HOT 4
- Job Summary Size Limitation aborts the job
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-review-action.