Comments (10)
@aaronosb I did! Thanks for sharing the repo details. I've shared this with other folks and will update this issue once I have a fix or feedback.
from dependency-review-action.
+1 as I got affected by this issue too.
We try to use mikro-orm/migrations
, depending on umzug
, depending on rushstack
, depending on [email protected]
.
from dependency-review-action.
@aaronosb @paulz-swyftx The API is now returning the proper results, and I've confirmed that the action is behaving as expected. I've created these two example PRs:
- future-funk/bug-free-sniffle#8 -- has
[email protected]
, does not raise errors since the vulnerability was introduced at[email protected]
. - future-funk/bug-free-sniffle#9 -- has
[email protected]
which has an open vulnerability since.0.0.0
with no fixes. This check fails.
Closing this issue, thanks for your patience! Please re-open if needed.
from dependency-review-action.
Hi @aaronosb, thanks for the report. From the screenshot it looks like you should not be getting this warning indeed, do you see the same error if you view the rich diff of the PR for the package-lock.json change? (docs on how to do this)
from dependency-review-action.
I do not get the same warning/error using the rich diff
from dependency-review-action.
@aaronosb If this is for a public repo, can you post a link? If not, can you email me the username/organization name and repo name to my username at github.com?
from dependency-review-action.
It was a private repo I can shoot you the info over in an email
from dependency-review-action.
@febuiles did you get the email with repo details?
from dependency-review-action.
@aaronosb apologies for the lack of feedback on this. After reproducing the issue I noticed that it's caused by the API itself and not the action:
$ gh api -H "Accept: application/vnd.github+json" /repos/future-funk/bug-free-sniffle/dependency-graph/compare/main...add-colors
[
{
"change_type": "added",
"manifest": "package-lock.json",
"ecosystem": "npm",
"name": "colors",
"version": "1.0.3",
"package_url": "pkg:npm/[email protected]",
"license": "MIT",
"source_repository_url": "https://github.com/Marak/colors.js",
"vulnerabilities": [
{
"severity": "high",
"advisory_ghsa_id": "GHSA-gh88-3pxp-6fm8",
"advisory_summary": "Infinite Loop in colors.js",
"advisory_url": "https://github.com/advisories/GHSA-gh88-3pxp-6fm8"
}
]
},
{
"change_type": "added",
"manifest": "package.json",
"ecosystem": "npm",
"name": "colors",
"version": "1.0.3",
"package_url": "pkg:npm/[email protected]",
"license": "MIT",
"source_repository_url": "https://github.com/Marak/colors.js",
"vulnerabilities": [
{
"severity": "high",
"advisory_ghsa_id": "GHSA-gh88-3pxp-6fm8",
"advisory_summary": "Infinite Loop in colors.js",
"advisory_url": "https://github.com/advisories/GHSA-gh88-3pxp-6fm8"
}
]
}
]
Once the API fix is released I will close this issue.
from dependency-review-action.
Thank you for the speedy response @febuiles
from dependency-review-action.
Related Issues (20)
- Unknown License but license available via github API HOT 2
- Package Deny List Ignores Version HOT 3
- Some Settings In External Configuration Overridden By Inline Defaults HOT 5
- Reachability - Add a flag to only block only on reachable dependencies.
- Invalid SPDX License should (as opt-in?) be counted as warning HOT 2
- Add Scopes to Scanned Manifest Files inventory
- Blocking issues (should block but does not) HOT 5
- Add list of resolved vulnerabilities to the PR Comment / Logs
- Invalid URL for OpenSSF Scorecard Package HOT 3
- Create a PR check for default values in action.yml
- Bug: Some repos get error "fetch failed" when fetching v4.2.3 HOT 3
- Action fails to decorate PR when text is too long HOT 2
- Deny Packages Icon should be Red X (not a yellow warning) HOT 3
- Feature Request: Block on unknown licenses HOT 1
- `warn_only` Does Not Apply When Using a Deny List HOT 1
- error "fetch failed" with v4.2.5 HOT 3
- Scorecard table URLs include duplicate https:// HOT 3
- MIT is an invalid SPDX license identifier? HOT 2
- Question: Is this action limited to revisions on the _default_ branch only? HOT 2
- Conflict between vulnerabilities in scorecard vs check
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-review-action.