Comments (2)
Perhaps this deserves some clarification.
This is:
A GitHub Action to
enable Pages and...
(see #40 (comment) for โน๏ธ on โ๐ป)
...extract various metadata about a site. It can also be used to configure various static site generators we support as starter workflows.
The goal of this Action is not to update your repository contents, though you could use it that way for supported static site generator configuration file modification. ๐ค
This Action's intent is to:
- (a)
optionally enable Pages for Actions-based deployments, if it is not already enabled- Again, this feature is currently disabled right now; see #40 (comment)
- (b) offer various site metadata to be used within your Actions workflows as needed, especially for deployment purposes
- (c) temporarily modify the configuration files of supported static site generators only for the duration of a workflow run so that configuration is included when building an artifact to be deployed, such as in the Pages starter workflows
Your site URLs should not be changing without input from the repository owner, such as when applying a custom domain name or changing the visibility of the Pages site, so I'm not sure how valuable it would be to be able to have a workflow specifically trigger on such modifications. The correct version of the site should arguably already have been deployed at that point, unless it's newly enabled. ๐ค
That said, as far as I know, you are correct that there currently are not applicable event triggers available for those scenarios as moving to deploying with GitHub Actions did change some of that event exposure. We should probably review those soon. ๐
from configure-pages.
Hmm I'm a little confused by those last paragraphs. Let me just provide some context of what I'm doing, so you see where I'm coming from.
I'm building a website template for people who are often non-technical. The biggest pain points I discovered were 1) baseurl
and 2) hooking up Netlify. People did not understand what baseurl
was, when/how to set it, or even that it was necessary for their website to work. Pull request previews were a needed feature, so I had instructions for how to hook up Netlify, but it was cumbersome and confusing. Thus, my goal is to use GitHub Actions to automate as much as humanly possible for the user. This includes automatically changing baseurl
when needed, do pr previews right on GitHub, and also things like initializing the readme, setting the repo description/homepage, etc. I would've loved to also enable GitHub Pages for them, but alas the security bug.
Because I need to do pr previews directly in GitHub, and it's not built-in yet, I'm having to use rossjrw/pr-preview-action
, which means that I must use pages in the classic way, with a gh-pages
branch.
It sounds like this action is more geared toward the new "build Pages from Actions" method, where we have a workflow that (as I understand it) GitHub runs "intelligently" whenever it needs to (a change in repo content, or a user changing the Pages url in the repo settings), and thus that workflow can always be sure it's building the site with the correct baseurl
.
In my case, I need to have a normal workflow that listens for pushes or other standard triggers, then builds the site and pushes it to the gh-pages
branch. The deployment
trigger is the only way I can see to listen for Pages domain changes in a standard workflow.
A secondary point... it sounds like you recommend always pulling the latest Pages url at build time, rather than having it statically in the repo in a _config.yaml
file or whatever. I guess I could do this in my approach just by adding deployment
as a trigger to the build workflow. However, I might argue the latter is better, as it's more explicit (not hidden magic going on in the workflow at build time), and building the site locally on your computer will more closely reflect the actual deployment environment. I'm still on the fence though.
Sorry for long winded discussion. In summary, I think the deployment
trigger is only needed if you're building Pages the "classic" way, and this action emphasize the "new" way, which I think is fine (but some sort of clarifying note might be prudent). Feel free to close the issue.
from configure-pages.
Related Issues (20)
- New configure
- Supported configuration file extension check does not use the per-generator default HOT 6
- Set `$BASE_URL` or similar env var for subsequent steps HOT 2
- Doesn't recognize next.config.mjs HOT 6
- Default configuration for next js needs to be updated HOT 2
- Major v5 HOT 4
- Zerea
- 35 HOT 2
- name: Static Analysis on: [push, pull_request] jobs: checks: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - uses: WillAbides/[email protected] with: go-version: '1.16.x' - name: Get dependencies run: | sudo apt-get update && sudo apt-get install gcc libgl1-mesa-dev libegl1-mesa-dev libgles2-mesa-dev libx11-dev xorg-dev go install golang.org/x/tools/cmd/goimports@latest go install github.com/fzipp/gocyclo/cmd/gocyclo@latest go install golang.org/x/lint/golint@latest go install honnef.co/go/tools/cmd/[email protected] - name: Cleanup repository run: rm -rf vendor/ - name: Vet run: go vet -tags ci ./... HOT 1
- ะะฟ HOT 1
- Wrong! Rename main.js to index.js
- Create Pages site failed: Resource not accessible by integration HOT 15
- Configuration seems to struggle with Next.js PWA configurations HOT 3
- Incorrect link "all code changes" for v3.0.0 release HOT 1
- Proxy issues when using self-hosted runners HOT 1
- [Next.js] basePath should be / when using a custom URL HOT 7
- The action ignores .ts config and creates default nuxt.config.js HOT 6
- thank u
- Add support for generating `preview: true` deployment environment URLs? ๐งช HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from configure-pages.