Giter Club home page Giter Club logo

Comments (6)

CashWilliams avatar CashWilliams commented on May 28, 2024 1

Used rsync --delete in the past, so ++ to that idea

from blt.

damontgomery avatar damontgomery commented on May 28, 2024

This will be an issue with class renaming. The old class files won't get deleted. :(

from blt.

damontgomery avatar damontgomery commented on May 28, 2024

The original goal was to prevent issues when the local site was not up to date. I recommend having the task fail in that case rather than do this weird work around.

  • Create deploy directory
  • Pull in the most recent version of the artifact branch
  • Wipe the directory outside of .git folder
  • Copy in the files as necessary
  • Attempt a commit / push

This will ensure that the build artifact is clean and there isn't extra stuff in there from before.

We could create an optional flag for the deploy task that force pushes in case something goes wrong.

from blt.

danepowell avatar danepowell commented on May 28, 2024

To be clear, I'm pretty sure this is only a problem for files that exist in the repo root or outside of the "standard" directories (i.e. docroot, config, hooks, etc...). Which begs the question... why are files being created outside of these directories? Seems like an edge case that could be handled with a custom deploy step.

On the other hand, I don't see a problem in just nuking the deploy directory before copying files there, or using rsync --delete. Although we'd want to make sure to leave the git directory intact.

from blt.

grasmash avatar grasmash commented on May 28, 2024

#162

from blt.

danepowell avatar danepowell commented on May 28, 2024

Seems like we can close this via #162

from blt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.