Comments (7)
I agree totally. I can think of at least one other download assist firefox extension that provides a preferences setting for specifying the full system path for ffmpeg. In fact, after installing, I renamed the ffmpeg binary installed locally by the coapp and created a symbolic link to the ffmpeg system binary in its place for it to use instead. A rather kludgy workaround, I know, but it seems to be working ok so far.
from vdhcoapp.
Bundling a version of ffmpeg was understandable under Debian's old multimedia policy. All current Debian and Ubuntu have ffmpeg in main/ now. The bundled version of ffmpeg may be vulnerable to more than a hundred security problems that have been fixed in ffmpeg since it was compiled: https://ffmpeg.org/security.html
Setting a depends: and removing the bundled version would prevent VDH from being a ready vector for malware.
Thanks for your support of the linux community.
from vdhcoapp.
I agree. We could do that.
If anyone is willing in contributing, i'd be happy to assist. Look up build.sh, all the magic is there.
Two things to do:
- fix build.sh to package without the ffmpeg binaries
- fix conerter.js to find the binaries in the system
from vdhcoapp.
I agree totally. I can think of at least one other download assist firefox extension that provides a preferences setting for specifying the full system path for ffmpeg. In fact, after installing, I renamed the ffmpeg binary installed locally by the coapp and created a symbolic link to the ffmpeg system binary in its place for it to use instead. A rather kludgy workaround, I know, but it seems to be working ok so far.
Nice little workaround, I'm gonna do that rightaway :) !
from vdhcoapp.
Done :) :
$ cd /opt/net.downloadhelper.coapp/converter/build/linux/64/
$ sudo mkdir -v BACKUP
mkdir: created directory ‘BACKUP’
$ sudo mv ff* lib* BACKUP/
$ sudo ln -vs $(which ffmpeg)
‘./ffmpeg’ -> ‘/usr/bin/ffmpeg’
$ sudo ln -vs $(which ffprobe)
‘./ffprobe’ -> ‘/usr/bin/ffprobe’
$ sudo ln -vs $(which ffplay)
‘./ffplay’ -> ‘/usr/bin/ffplay’
$ ls -l
total 12
drwxr-xr-x 1 root root 1178 mars 29 16:52 BACKUP
lrwxrwxrwx 1 root root 15 mars 29 16:52 ffmpeg -> /usr/bin/ffmpeg
lrwxrwxrwx 1 root root 15 mars 29 16:53 ffplay -> /usr/bin/ffplay
lrwxrwxrwx 1 root root 16 mars 29 16:52 ffprobe -> /usr/bin/ffprobe
$
from vdhcoapp.
-
Depending on where your net.downloadhelper.coapp gets installed, and the permissions of that folder/tree branch, you may or may not need sudo or root permissions to do this. I see you installed it system-wide in /opt on your setup; I installed it in a somewhat arbitrary sub-folder location in my home directory, hence the permissions consideration.
-
While you're there, you may want to do the same for ffplay and ffprobe. That's apparently what I did on my system. Ok, as I looked now, I see your edits there, updated to include that.
-
'ln -sv' = 'ln -s -v'
from vdhcoapp.
- Depending on where your net.downloadhelper.coapp gets installed, and the permissions of that folder/tree branch, you may or may not need sudo or root permissions to do this. I see you installed it system-wide in /opt on your setup; I installed it in a somewhat arbitrary sub-folder location in my home directory, hence the permissions consideration.
...
The answer to "1." : I installed this package for Ubuntu/Debian :
$ dpkg-deb -c net.downloadhelper.coapp-1.4.0-1_amd64.deb | grep ffmpeg$
-rwxr-xr-x 0/0 264320 2019-06-19 15:52 opt/net.downloadhelper.coapp/converter/build/linux/64/ffmpeg
from vdhcoapp.
Related Issues (20)
- Windows 32bits / 64bits mixup
- linux deb install doesn't support LibreWolf (firefox variant) HOT 2
- My resistration key for this app and the browser extensions completely disapearerd after upgrading them and now QRcode storms in video. HOT 1
- `/opt/vdhcoapp/vdhcoapp install` does not create net.downloadhelper.coapp.json for flatpak-installed Edge despite linking itself in its sandbox HOT 4
- main extension default-action shortcut bug HOT 16
- [Proxy issue] GrabInfo: Cannot get info from HOT 6
- Proxy feature not working HOT 2
- Install via brew? HOT 1
- Coapp install on linux mint to VDH HOT 1
- Any support for Mac 10.11 El Capitan? HOT 1
- migrate from pkg to "Single executable applications" HOT 1
- replace filepicker with zenity HOT 3
- The video-download can't see Companion App in ubuntu 22.04 for firefox, can anyone to help me please ???? HOT 1
- How do I uninstall the helper app? HOT 2
- Add build for Windows ARM
- How to refresh detection? HOT 10
- Cloudflare returns Error code 520 HOT 4
- Uninstallation Question About Flatpak Linking HOT 4
- bash cannot find vdhcoapp file? HOT 10
- File name of downloaded videos HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vdhcoapp.