Giter Club home page Giter Club logo

Comments (9)

lberrymage avatar lberrymage commented on June 24, 2024 5

I'm going to decline this feature for now under the premise that it may become more effort to maintain over time to ensure the deep black doesn't inadvertently conflict/merge with other UI elements. Part of the rationale for using Material 3 consistently is avoiding accumulating UI color quirks as more elements are added.

If there's significant interest in the future I may reconsider, but I can't really justify it now.

from accrescent.

lberrymage avatar lberrymage commented on June 24, 2024

I'm not sure I want to have this implemented. Generally the Material spec is good at maintaining appealing color contrast, and having a full black background doesn't really do that. There are advantages to Accrescent having a consistent look as well.

Curious what others have to say.

from accrescent.

soupslurpr avatar soupslurpr commented on June 24, 2024

Fair, but I did see that when the pitch black background is on, it seems the other colors adjust to it

Edit: actually only the bottom bar color gets adjusted

from accrescent.

PatrykMis avatar PatrykMis commented on June 24, 2024

Personally I more like Accrescent when black variant of dark theme in LineageOS is turned on, which is impossible on e.g. GrapheneOS. If pitched black works similarly as with black theme turned on LineageOS I'd prefer to have this option.

from accrescent.

BHydden avatar BHydden commented on June 24, 2024

I also prefer black theme

from accrescent.

idk-r-n avatar idk-r-n commented on June 24, 2024

I'm not sure I want to have this implemented. Generally the Material spec is good at maintaining appealing color contrast, and having a full black background doesn't really do that. There are advantages to Accrescent having a consistent look as well.

Curious what others have to say.

Don't cave to the pressure. You are correct. 🌙🌙🌙

from accrescent.

 avatar commented on June 24, 2024

I'm not sure I want to have this implemented. Generally the Material spec is good at maintaining appealing color contrast, and having a full black background doesn't really do that. There are advantages to Accrescent having a consistent look as well.

Curious what others have to say.

You are right.
I vote for not implementing this.
Even if you implement it, make it as a toggle and turn the toggle off by default.
Pls don't do the way Molly does.

from accrescent.

PatrykMis avatar PatrykMis commented on June 24, 2024

Absolutely agree with turning it off by default if you finally implement it.

from accrescent.

soupslurpr avatar soupslurpr commented on June 24, 2024

Absolutely agree with turning it off by default if you finally implement it.

Yeah, its off by default in my pull request #280

from accrescent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.