Quotation marks in variable values about cicero-word-add-in HOT 9 CLOSED

@K-Kumar-01 thanks for raising the issue.

I think the extra "" are not put intentionally. They come directly from CiceroMark JSON of a sample text of a particular template. As far as I remember the values in the CiceroMark JSON were stored like this - {name: "\"Party A\""}.

I might be wrong though. Could you please confirm, @irmerk @K-Kumar-01 ?

from cicero-word-add-in.

That sounds right. Probably something we didn't want to bother with last summer at the time.

from cicero-word-add-in.

I had a similar doubt, when the user edits a variable, it allows them to remove the double-quotes. Was it intentional or we want to preserve the double-quotes as well?

from cicero-word-add-in.

@algomaster99 any thoughts on this? I don't recall why we needed quotation marks.

from cicero-word-add-in.

@algomaster99
The values in JSON mark are as follows

$class: "org.accordproject.ciceromark.Variable"
elementType: "org.accordproject.organization.Organization"
identifiedBy: "identifier"
name: "shipper"
value: ""Party A""

So yeah basically what you are saying is right.
However, in contract-editor (web-components), the values do not contain the "" wrapped around them. This led me to think that these might be unintentional when it gets converted to CiceroMark JSON.
Maybe you or @irmerk can explain better to me about this

from cicero-word-add-in.

@algomaster99 @irmerk
Should I make a PR for the issue.

from cicero-word-add-in.

@K-Kumar-01 you can go ahead. The contract editor probably strips the "" out of the variable value so do how its done in there. Also, make sure roundtripping is not broken because of this.

from cicero-word-add-in.

@algomaster99
In contract editor, there is no extra "" in the values.

So I don't think we can use its implementation for the same.
Though I have found a solution for which I make a PR ASAP.

from cicero-word-add-in.

@algomaster99
I have made a PR for the issue. Let me know if there are any changes required.

from cicero-word-add-in.