Giter Club home page Giter Club logo

Comments (6)

jstone-lucasfilm avatar jstone-lucasfilm commented on September 25, 2024 1

Just to provide an external reference point, the MaterialX graph for Autodesk Standard Surface uses 1.0 as the uisoftmin for specular IOR:

https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/libraries/bxdf/standard_surface.mtlx#L29

from openpbr.

portsmouth avatar portsmouth commented on September 25, 2024

@kikou wrote:

  • IOR below 1 is physically possible. People usually object you cannot have a velocity higher than the speed of light, but since this is the phase velocity, it does not carry information and thus can exceed the speed of light. See https://en.wikipedia.org/wiki/Refractive_index

  • IOR below 1 is useful in production when the default medium is not air, like for underwater scenes. It can be more practical to use the inverse IOR for bubbles for example.

from openpbr.

portsmouth avatar portsmouth commented on September 25, 2024

IOR below 1 is physically possible.

Physically possible, but exceedingly exotic, as in nothing you encounter in everyday life has such an IOR (you could say, physically implausible).

IOR below 1 is useful in production when the default medium is not air, like for underwater scenes.

Yes I'm aware, though I think what is happening there is that people are exploiting the fact that shaders treat the value as the ratio between the IORs of the interior and exterior, which can be <1 if the outside is denser (e.g. as in light exiting an air bubble in water, ratio = 1/1.3). Really the system should determine that ratio from the properties of the media (as is done in nested dielectrics), which will all have IOR >= 1 (e.g. air=1, water=1.3) unless they are exotic.

Though in practice systems may not have implemented nested dielectrics etc., so I know it's a useful hack. We could at least make it a soft-min at 1.

from openpbr.

portsmouth avatar portsmouth commented on September 25, 2024

@peterkutz wrote:

Making it a soft-min at 1 seems reasonable.

from openpbr.

virtualzavie avatar virtualzavie commented on September 25, 2024

In #56 the range of IOR is set to $(0, \infty)$ while the recommanded/UI/soft range is set to $[1, 3]$.

from openpbr.

portsmouth avatar portsmouth commented on September 25, 2024

Was addressed in #56.

from openpbr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.