Comments (5)
Fair enough, we can put a soft-max and see if we have feedback on it. For sliders in scene units, 1 seems reasonable indeed.
A paragraph on the topic could be useful as well.
from openpbr.
@virtualzavie Do you mind to make a pull request for this?
from openpbr.
This is difficult since it depends on the scene units, and the length scale of the object being rendered. A depth of 1e6 would be reasonable when rendering a 1km wide body of water in mm units, say, though that's probably atypical.
However if you make the upper limit too large, then the user ends up with a useless slider most of the time. In Maya transmission_depth
(soft) maxes out at 100.0, so if you're working in the default cm units with some volume with a MFP of O(1cm) (e.g. orange juice), the slider is functionally useless.
Similarly for subsurface_radius
which (soft) maxes out at 10.0 while skin MFP is typically O(1mm).
I think this is really a UI problem though, i.e. the solution is better slider UIs where you can easily adjust the range for convenience.
In the meantime, I'd propose a soft-max of 1.0. At least then for typical objects/units (where MFP and units are roughly in the same ballpark) the slider will do something useful over most of the range, and it's a soft-max so seems more appropriate for it to be too small than too large (i.e. it's more natural to increase it as needed, rather than decrease it from some large default value).
from openpbr.
Will do.
from openpbr.
Thanks for this recommendation, @virtualzavie, as well as for the fix in #114. I'll go ahead and mark this as resolved.
from openpbr.
Related Issues (20)
- Dielectric priority? HOT 1
- Ordering of the parameters HOT 1
- Fuzz normal when layered on top of coat HOT 3
- Clarify handling of rays incident to the surface from the interior HOT 1
- For consistency, every section should have a "weight" parameter. HOT 2
- Better approximation for darkening layers under coat HOT 14
- Suggest "presence" or "coverage" instead of "geometric_opacity" HOT 1
- Suggest "0.18" as the default base_color HOT 1
- Suggest separate parameters for diffuse and metal colours instead of "base_color" HOT 4
- Glossy-diffuse slab description as a gloss layer is possibly confusing HOT 2
- Coat/specular IOR defaults, and TIR issue if coat IOR > spec IOR HOT 3
- Spec/coat roughness ranges should be [0,1]
- subsurface_radius_scale should maybe be a color (not a vector3)?
- specular_color should not generate a complementary color HOT 1
- State white-furnace test behavior HOT 2
- MaterialX reference implementation errors HOT 2
- Emission units HOT 6
- MaterialX implementation HOT 1
- Definition of angle for F82 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openpbr.