Giter Club home page Giter Club logo

Comments (4)

TeriForey avatar TeriForey commented on September 17, 2024 1

Thanks @aburrell that looks to have fixed the bug. The test works and I can see the deprecation warning when using code.

from aacgmv2.

aburrell avatar aburrell commented on September 17, 2024

Thanks for finding this. Looking at the code, I remember now that this was changed in response to a request for having more descriptive variable names. I can probably get to this next week. Here's what I plan to do:

  1. update the documentation
  2. update the changelog
  3. add an option to use code, but its use will trigger a deprecation warning that the user should switch to method_code
  4. schedule the removal of code for the release of version 2.5.4

I was getting ready to release version 2.5.3, but will get this in first.

from aacgmv2.

aburrell avatar aburrell commented on September 17, 2024

@TeriForey, would you be able to run the test in pull request #45 to ensure that the behavior fixes the code bug you found?

from aacgmv2.

aburrell avatar aburrell commented on September 17, 2024

@TeriForey I will let you know when the new version with this change comes out (realistically, before Christmas). In the meantime, I am merging this fix into develop.

from aacgmv2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.