Giter Club home page Giter Club logo

Comments (5)

benwilson512 avatar benwilson512 commented on August 19, 2024

So this is the default response if the content type is application/html right?

This should be off by default in production?

from absinthe_plug.

bruce avatar bruce commented on August 19, 2024

So this is the default response if the content type is application/html right?

Whatever express-graphql does, and it can't interfere with any HTML bits the host app is serving, of course.

This should be off by default in production?

Yes, and on by default in development, and overridable on/off for either. This may differ from express-graphql a bit -- I think theirs is just an option you pass in, and it's falsey by default.

from absinthe_plug.

bruce avatar bruce commented on August 19, 2024

Also, ninja-adding an interface by default probably warrants a bump to v1.1.

from absinthe_plug.

benwilson512 avatar benwilson512 commented on August 19, 2024

Current plans:

This should be a separate plug. We'll need to refactor out common functionality from the existing plug because it'll be used in both cases. This will make it easy to configure it along side regular graphql functionality in variety of ways. One could forward to it from a router etc.

from absinthe_plug.

bruce avatar bruce commented on August 19, 2024

Resolved by #15

from absinthe_plug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.