Giter Club home page Giter Club logo

Comments (6)

abe33 avatar abe33 commented on August 20, 2024

Hmm, that's actually not true for font size and line height when modified from the settings, but it's true I don't listen to stylesheets changes. It shouldn't be too hard to fix.

from atom-pigments.

AlexTuduran avatar AlexTuduran commented on August 20, 2024

Actually I remember I've tested changing font attributes from settings as well just to check if there's a different behavior, but it seems I get the same results. The only way to heal it is to edit the line containing the color declaration, only then the pigments relocate.

from atom-pigments.

abe33 avatar abe33 commented on August 20, 2024

Are you sure about changing the settings not affecting the markers?

Because as far as I can tell it works, and there's even tests for that:

pigments-resize

The tests:
https://github.com/abe33/atom-pigments/blob/master/spec/color-buffer-element-spec.coffee#L254-L270

from atom-pigments.

AlexTuduran avatar AlexTuduran commented on August 20, 2024

I've checked this usecase specifically then and the problem existed, but now it seems the pigments update when changing font attributes from settings, so it seems you're right on this one, my apologies.

from atom-pigments.

abe33 avatar abe33 commented on August 20, 2024

No pb, there's always some cases I didn't foresee that may not work, but if I've written tests for a given use case I'm generally pretty confident about them working properly. To being cautious I'll also add a listener to the stylesheets changes events in the next release.

from atom-pigments.

AlexTuduran avatar AlexTuduran commented on August 20, 2024

Sounds great! Really useful package btw!

from atom-pigments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.