Giter Club home page Giter Club logo

Comments (3)

aaugustin avatar aaugustin commented on July 29, 2024

Thanks for the report

We need to improve this check:

browser = user_agent_parser.ParseUserAgent(user_agent)["family"]
return browser == "Safari"

Here are some browsers families that may have ITP:

$ grep family uap.yaml | grep -v '#' | sort | uniq | grep '\(Apple\|Safari\|WebKit\)'
    family_replacement: 'Apple Mail'
    family_replacement: 'BlackBerry WebKit'
    family_replacement: 'Mobile Safari UI/WKWebView'
    family_replacement: 'Mobile Safari'
    family_replacement: 'Safari'
    family_replacement: 'WebKit Nightly'

You report that it happens on all mobile browsers on iOS (and, I guess, tvOS). This means we also need to test for the OS in addition to the browser family.

I knew that all iOS browsers must use WebKit for rendering; I wasn't sure if that included cookie management; apparently it does.

A PR would be much appreciated :-)

from django-sesame.

aaugustin avatar aaugustin commented on July 29, 2024

I pushed a new release to PyPI with your fix to make it easier for you to deploy it.

from django-sesame.

pjsier avatar pjsier commented on July 29, 2024

Great, thanks for the quick review!

from django-sesame.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.