Proposal for new Context pattern about activeinteractor HOT 6 CLOSED

I definitely think the new proposed architecture is nicer.

Providing a way for the user to specify their own context class is going to make your library more extensible and powerful, and saves me as an end user from monkey patching your code anyway.

I also think context_attributes is too awkward, and much prefer your newer syntax and making it explicit that you're declaring props on a context class that you're also declaring vs an automagical declared context.

I do prefer the sub-classed Context naming convention you had before, for example:
MyInteractor::Context vs MyInteractorContext, but it's a minor thing.

from activeinteractor.

What if the default behavior is to create a class (current behavior), unless one with the appropriate naming convention already exists?

In that case the naming convention might even be overkill, and using the self.context_class is the defacto way to do it.

from activeinteractor.

I think it would also be beneficial to allow for an interactor to define it's own context class to allow for classes that don't meet the expected naming convention.

class User < ActiveRecord::Base
end

class AuthenticateUser < ActiveInteractor::Base
  self.context_class = User
end

from activeinteractor.

from activeinteractor.

@zacharyw so instead of falling back to a generic context class with no validations and no attribute methods you're suggesting the fallback would be the current behavior?

from activeinteractor.

@aaronmallen I think so. I do see the benefit of being able to set a custom context, but for a lot of simple base case scenarios it may be annoying to have to manually keep creating new classes.

from activeinteractor.