The use of classify is not documented which produces unexpected singularization of class names in organizers about activeinteractor HOT 10 CLOSED

I've also noticed if the class is called CleanupFiles same issue. It could be because I'm not using symbols for class names, but I can't since I'm relying on modules.

While I'm here. I've noticed another possible issue. If some of the interactors of the organizer fail context.fail!('Error Message') error message is not persisted.

[10] pry(main)> stripe = StripeCustomer::UpdateCustomer.perform(user: user, params: params)
stripe.success?
=> false

[10] pry(main)> stripe.errors
=> #<ActiveModel::Errors:0x00007fa730422528
 @base=
  #<StripeCustomer::UpdateCustomer::Context user=#<User id: 104..>, params={...}>,
 @details={},
 @messages={}>

Thank you for looking into this.

@majksner could you file a separate bug for this?

from activeinteractor.

Instead of a documentation change we will use camelize instead of classify to safe_constantize class names. If I have a class defined like PrepareData and I pass an argument to the organize method like :prepare_data, "PrepareData", or PrepareData I should reasonably expect this argument would not be singularized down the chain. Closing this bug as won't fix.

see #168 and #171

from activeinteractor.

This is possibly a bug, let me investigate this evening.

from activeinteractor.

@majksner can you add the contents of the interactors themselves?

from activeinteractor.

🤔 I've done a bit of testing and it appears to be an issue with the class name Order::PrepareData specifically.

from activeinteractor.

I've also noticed if the class is called CleanupFiles same issue. It could be because I'm not using symbols for class names, but I can't since I'm relying on modules.

While I'm here. I've noticed another possible issue. If some of the interactors of the organizer fail context.fail!('Error Message') error message is not persisted.

[10] pry(main)> stripe = StripeCustomer::UpdateCustomer.perform(user: user, params: params)
stripe.success?
=> false

[10] pry(main)> stripe.errors
=> #<ActiveModel::Errors:0x00007fa730422528
 @base=
  #<StripeCustomer::UpdateCustomer::Context user=#<User id: 104..>, params={...}>,
 @details={},
 @messages={}>

Thank you for looking into this.

from activeinteractor.

This appears to be an issue with constantize in ActiveSupport:

irb(main):005:0> "PrepareData".classify
=> "PrepareDatum"

from activeinteractor.

I see it singularizes string.

[2] pry(main)> "PrepareFiles".classify
=> "PrepareFile"
[3] pry(main)> "PrepareThings".classify
=> "PrepareThing"
[4] pry(main)> "Generates".classify
=> "Generate"

Maybe I can send you a pull request for documentation to mention this? Aside from this, putting organizers into modules that I mentioned at the beginning of this issue is a way to go or you have a better suggestion?

from activeinteractor.

The issue isn't the nested modules, it's the class names themselves. classifywill return PlaceDataum or Order::PlaceDatum.

from activeinteractor.

I've also added a new bug, #168, for this... for Symbol or String the fix should be to document the use of classify, however If I pass a Class or Module directly I would expect that to be found correctly.

from activeinteractor.