Comments (1)
This turns out to be an interesting issue. Prior to 4.0.0 we would populate the object with the raw value provided in the input and then override them with the filtered value. I think we did it that way at the time to preserve the raw values for use in errors but I don't exactly remember. The result of this is that in some cases what you noticed would work. The raw value given was available and used in the provided default proc and functioned correctly. This however, was luck.
Here's an example (using 3.8.3):
class Test < ActiveInteraction::Base
integer :a, default: -> { b + 1 }
integer :b
def execute
a
end
end
> Test.run!(b: 2) # => 3
> Test.run!(b: '2') # => TypeError (no implicit conversion of Integer into String)
This happens because the b
value was not converted into an integer so when we try to add 1
to it we get an error. If you flip the order of :a
and :b
it does work.
The real error here is that we wrote improper values in the first place. In a way this error was accidentally fixed in 4.0.0.
I'm sorry it caused confusion. That's certainly frustrating. I've thought about ways to help this and the best I can think of is to process the inputs first by filters without default procs, then any inputs passed, and finally filters that received no input and have a default proc. The issue is that we still have the same issue with any of those final filters with no inputs and default procs. We've shrunk the chances of it happening but it's much more confusing for someone to reason about and much more prone to failing in a surprising way. I think having them work in order is probably the best bet.
from active_interaction.
Related Issues (20)
- Converter object filter doesn't work when default is nil HOT 2
- Handling nested attributes (hash of hashes) HOT 3
- v5 gemspec tied to rails gem and thereby activerecord HOT 1
- Incorrect filtering of array of hashes in v5? HOT 1
- Activeinteraction::Inputs and ActiveRecord #build_where_clause HOT 1
- Bug: Cached default input values HOT 1
- Question: Would you like to add some hactoberfest labels? HOT 1
- Rails 7: ArgumentError (Could not find or build blob: expected attachable) HOT 1
- An `array` filter can mutate the state of the passed in Array instance
- array :emails is always nil. Why? HOT 2
- Missing some documentation on nested hash default options HOT 4
- `ActiveInteraction::Errors#merge!` does not merge custom options HOT 4
- Input access consistency issues HOT 2
- Something strange with full_messages method for errors HOT 2
- When use callback - compose work strange in interaction HOT 1
- Enum filter HOT 2
- Array Filter with default values aren't initialized on each run HOT 2
- Document typecasting to HashWithIndifferentAccess
- Nested forms HOT 4
- Two datatypes with same variable name HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from active_interaction.