Giter Club home page Giter Club logo

Comments (8)

tfausak avatar tfausak commented on July 23, 2024

I don't think we should do this. The benefit of doing this would be that all inputs must be specified. You couldn't create an interaction with one top-level hash that you pluck values out of arbitrarily. However, it would still be possible to do that with an array, since they can hold any number of anything.

from active_interaction.

tfausak avatar tfausak commented on July 23, 2024

I think we should revisit this one. If you want to loop over all the keys in a hash, you shouldn't have to worry about rogue values sneaking in:

class Interaction < ActiveInteraction::Base
  hash :a
  def execute
    a.each { |k, v| puts "#{k} => #{v}" }
  end
end
Interaction.run(a: { x: true })
# x => true

from active_interaction.

tfausak avatar tfausak commented on July 23, 2024

Maybe this should be an option.

from active_interaction.

tfausak avatar tfausak commented on July 23, 2024

I'm thinking the option should be called strict and it should default to true. Here's how it would work:

class Interaction < ActiveInteraction::Base
  hash :a, strict: false do
    hash :x
  end
  def execute; a end
end
Interaction.run!(a: { x: { y: false }, z: true })
# => { x: {}, z: true }

from active_interaction.

AaronLasseigne avatar AaronLasseigne commented on July 23, 2024

👍

from active_interaction.

tfausak avatar tfausak commented on July 23, 2024

How should this behave with defaults?

class Interaction < ActiveInteraction::Base
  hash :a, default: { x: true }
  def execute; a end
end
Interaction.run!
# => {} or { x: true }?

from active_interaction.

AaronLasseigne avatar AaronLasseigne commented on July 23, 2024

I would think {x: true}.

from active_interaction.

tfausak avatar tfausak commented on July 23, 2024

Fixed by #69.

from active_interaction.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.