Strip keys from hashes? about active_interaction HOT 8 CLOSED

I don't think we should do this. The benefit of doing this would be that all inputs must be specified. You couldn't create an interaction with one top-level hash that you pluck values out of arbitrarily. However, it would still be possible to do that with an array, since they can hold any number of anything.

from active_interaction.

I think we should revisit this one. If you want to loop over all the keys in a hash, you shouldn't have to worry about rogue values sneaking in:

class Interaction < ActiveInteraction::Base
  hash :a
  def execute
    a.each { |k, v| puts "#{k} => #{v}" }
  end
end
Interaction.run(a: { x: true })
# x => true

from active_interaction.

Maybe this should be an option.

from active_interaction.

I'm thinking the option should be called strict and it should default to true. Here's how it would work:

class Interaction < ActiveInteraction::Base
  hash :a, strict: false do
    hash :x
  end
  def execute; a end
end
Interaction.run!(a: { x: { y: false }, z: true })
# => { x: {}, z: true }

from active_interaction.

👍

from active_interaction.

How should this behave with defaults?

class Interaction < ActiveInteraction::Base
  hash :a, default: { x: true }
  def execute; a end
end
Interaction.run!
# => {} or { x: true }?

from active_interaction.

I would think {x: true}.

from active_interaction.

Fixed by #69.

from active_interaction.